stable
Clone or download
Read-only
part of story #10710 search on fields with duck typing No functional change. CI should be happy. Why? This is part of a refactoring to transition away from invalid checks being grouped by comparison type (equals, lesser than, etc.). We want to group it by field type instead, as it is easier to understand. Most of the time, we work "field by field", so it makes more sense to have all the business rules for a given field in as few files as possible, instead of having all the business rules for "equals" comparison being grouped together. Change-Id: I51f4e078f0f4240b05536c6b107265d002d692d9
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/InvalidTermCollectorVisitor.php | +24 | −6 | Go to diff View file |
| M | plugins/crosstracker/tests/unit/CrossTracker/Report/Query/Advanced/InvalidTermCollectorVisitorTest.php | +135 | −24 | Go to diff View file |
| M | plugins/crosstracker/tests/unit/CrossTracker/Report/Query/Advanced/QueryBuilder/Field/FieldFromWhereBuilderTest.php | +2 | −10 | Go to diff View file |
| M | plugins/crosstracker/tests/unit/CrossTracker/Report/Query/Advanced/QueryValidation/Field/FieldUsageCheckerTest.php | +3 | −0 | Go to diff View file |
| M | plugins/crosstracker/tests/unit/CrossTracker/Tests/Builders/InvalidSearchableCollectorParametersBuilder.php | +20 | −2 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Report/Query/Advanced/CollectionOfListValuesExtractor.php | +9 | −4 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Report/Query/Advanced/Grammar/CurrentUserValueWrapper.php | +11 | −11 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/EqualComparisonVisitor.php | +4 | −29 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/FlatInvalidFieldChecker.php | +21 | −19 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/InComparisonVisitor.php | +4 | −7 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/ListFields/ListFieldChecker.php | +48 | −40 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/NotEqualComparisonVisitor.php | +4 | −7 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/NotInComparisonVisitor.php | +4 | −7 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidTermCollectorVisitor.php | +16 | −0 | Go to diff View file |
| A | plugins/tracker/tests/unit/Builders/Fields/CheckboxFieldBuilder.php | +91 | −0 | Go to diff View file |
| A | plugins/tracker/tests/unit/Builders/Fields/RadioButtonFieldBuilder.php | +91 | −0 | Go to diff View file |
| D | plugins/tracker/tests/unit/Tracker/Report/Query/Advanced/InvalidFields/ListFieldCheckerWithBindStaticTest.php | +0 | −135 | Go to diff View file |
| D | plugins/tracker/tests/unit/Tracker/Report/Query/Advanced/InvalidFields/ListFieldCheckerWithBindUgroupsTest.php | +0 | −184 | Go to diff View file |
| D | plugins/tracker/tests/unit/Tracker/Report/Query/Advanced/InvalidFields/ListFieldCheckerWithBindUsersTest.php | +0 | −173 | Go to diff View file |
| A | plugins/tracker/tests/unit/Tracker/Report/Query/Advanced/InvalidFields/ListFields/ListFieldCheckerWithBindStaticTest.php | +96 | −0 | Go to diff View file |
| A | plugins/tracker/tests/unit/Tracker/Report/Query/Advanced/InvalidFields/ListFields/ListFieldCheckerWithBindUgroupsTest.php | +132 | −0 | Go to diff View file |
| A | plugins/tracker/tests/unit/Tracker/Report/Query/Advanced/InvalidFields/ListFields/ListFieldCheckerWithBindUsersTest.php | +142 | −0 | Go to diff View file |
| M | plugins/tracker/tests/unit/Tracker/Report/Query/Advanced/InvalidTermCollectorVisitorTest.php | +143 | −24 | Go to diff View file |
| M | plugins/tracker/tests/unit/Tracker/Report/Query/Advanced/UgroupLabelConverterTest.php | +2 | −4 | Go to diff View file |
| A | tests/lib/LegacyTabTranslationsSupport.php | +43 | −0 | Go to diff View file |
| M | tests/unit/common/language/BaseLanguageFactoryTest.php | +2 | −7 | Go to diff View file |