Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Extract webhook secret checks in a dedicated object

Download Browse

This is part of story #17178 reference my gitlab repositories in my tuleap project This is a technical refactoring. No functional change expected here. Change-Id: Ia7bc3c7fd77ead5a49e15ca994def892b7d06e44

+230 −38
Yannis ROSSETTO (rossettoy) 2020-11-03 16:47
Yannis ROSSETTO (rossettoy) 2020-11-03 16:47
7ac1fc8415da6482523f92ab7d13704f69319796
3770fc763694d1d62f6bba30fa195d7118cf001d
git #tuleap/stable/7ac1fc8415da6482523f92ab7d13704f69319796

Modified Files

Side by side diff
Inline diff
Name
A plugins/gitlab/include/Repository/Webhook/Secret/SecretChecker.php +63 −0 Go to diff View file
M plugins/gitlab/include/Repository/Webhook/Secret/SecretHeaderNotFoundException.php +1 −3 Go to diff View file
M plugins/gitlab/include/Repository/Webhook/WebhookDataExtractor.php +9 −30 Go to diff View file
M plugins/gitlab/include/gitlabPlugin.php +7 −4 Go to diff View file
A plugins/gitlab/tests/unit/Repository/Webhook/Secret/SecretCheckerTest.php +142 −0 Go to diff View file
M plugins/gitlab/tests/unit/Repository/Webhook/WebhookDataExtractorTest.php +8 −1 Go to diff View file