Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

design: Don't display a border below PR infos when user cannot write

Download Browse

part of story #31186 Add management of "Merge" As per the mockups, when the PR is open and the user has not the right to merge the pull-request, the component containing this button is not displayed. However, there should not be a border below the PR infos if the component is hidden. How to test: - Go to a pull-request with a user only having READ permissions in the repository --> No border is displayed below the PR info section Change-Id: Ia6b478be97006c12ced7aad509eea35fd69ecb84

+98 −31
Thomas Gorka (tgorka) 2023-03-27 14:54
Thomas Gorka (tgorka) 2023-03-27 14:54
7c38de584dae16b6d1232225c7832edb7583e5bb
a37109524d4cdb52ed28cc5ce63bca9de6fe25d5
git #tuleap/stable/7c38de584dae16b6d1232225c7832edb7583e5bb

Modified Files

Side by side diff
Inline diff
Name
M plugins/pullrequest/scripts/pullrequest-overview/src/components/Actions/PullRequestAlreadyMergedState.vue +2 −2 Go to diff View file
M plugins/pullrequest/scripts/pullrequest-overview/src/components/Actions/PullRequestChangeStateActions.test.ts +29 −0 Go to diff View file
M plugins/pullrequest/scripts/pullrequest-overview/src/components/Actions/PullRequestChangeStateActions.vue +20 −3 Go to diff View file
M plugins/pullrequest/scripts/pullrequest-overview/src/components/Actions/PullRequestMergeButton.vue +4 −2 Go to diff View file
M plugins/pullrequest/scripts/pullrequest-overview/src/components/Actions/merge-status-helper.test.ts +18 −6 Go to diff View file
M plugins/pullrequest/scripts/pullrequest-overview/src/components/Actions/merge-status-helper.ts +19 −7 Go to diff View file
M plugins/pullrequest/scripts/pullrequest-overview/src/components/OverviewPane.vue +6 −11 Go to diff View file