Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refacto: stop repeating ourself when we retrieve field that user can

Download Browse

read Part of story #39685 Order artifact according to a field No functional change expected Change-Id: Iffe298becb300407cab51eea1a13c52b6be6056b

+211 −89
Clarck Robinson (robinsoc) 2024-09-25 17:45
Clarck Robinson (robinsoc) 2024-09-26 17:31
7e26e1a74156e88ddb0f8ceea64f2536e31d3814
19ec410fe5f8d58bc10d6712812bb0a09664d1d9
git #tuleap/stable/7e26e1a74156e88ddb0f8ceea64f2536e31d3814

Modified Files

Side by side diff
Inline diff
Name
A plugins/crosstracker/include/CrossTracker/Field/ReadableFieldRetriever.php +57 −0 Go to diff View file
M plugins/crosstracker/include/CrossTracker/REST/v1/CrossTrackerReportsResource.php +8 −6 Go to diff View file
M plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/OrderByBuilder/Field/FieldFromOrderBuilder.php +3 −16 Go to diff View file
M plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/QueryValidation/DuckTypedField/DuckTypedFieldChecker.php +4 −26 Go to diff View file
M plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/ResultBuilder/Field/FieldResultBuilder.php +4 −16 Go to diff View file
M plugins/crosstracker/include/crosstrackerPlugin.php +10 −7 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Tests/Report/ArtifactReportFactoryInstantiator.php +11 −8 Go to diff View file
A plugins/crosstracker/tests/unit/CrossTracker/Field/ReadableFieldRetrieverTest.php +83 −0 Go to diff View file
M plugins/crosstracker/tests/unit/CrossTracker/Report/Query/Advanced/InvalidOrderByBuilderTest.php +5 −1 Go to diff View file
M plugins/crosstracker/tests/unit/CrossTracker/Report/Query/Advanced/InvalidSelectablesCollectionBuilderTest.php +7 −2 Go to diff View file
M plugins/crosstracker/tests/unit/CrossTracker/Report/Query/Advanced/InvalidTermCollectorVisitorTest.php +5 −1 Go to diff View file
M plugins/crosstracker/tests/unit/CrossTracker/Report/Query/Advanced/QueryValidation/DuckTypedField/DuckTypedFieldCheckerTest.php +5 −1 Go to diff View file
M plugins/crosstracker/tests/unit/CrossTracker/Report/Query/Advanced/ResultBuilder/Field/FieldResultBuilderTest.php +9 −5 Go to diff View file