stable
Clone or download
Part of story #11543 Use new palette colors as background color in A.D I took the opportunity to refactor the "time info" clock into a dedicated component. This brings the following improvements: - the clock is now fully replaced by an "updating" spinner instead of css "hacks" to hide it to show a background image on the whole card. - the time info title is a one-time binding, which means Angular does not waste time recomputing it for every card every split second during drag and drop - Reduced unmaintainable $scope dependencies between kanban-item and kanban controller (but some are still there) How to test: - The clock icon should be horizontally centered with regards to the accessibility pattern - The clock icon should be shown for all columns except Backlog - It should still show a localized message stating the time the item has been in Kanban and in its current column - It should be replaced by an "updating" spinner when the card is drag and dropped or edited - "Updating" cards keep their background color Change-Id: Ica83631abd881ababf1957321e46180cedab2a5b
Modified Files
Name | ||||
---|---|---|---|---|
M | plugins/agiledashboard/www/js/kanban/po/template.pot | +2 | −2 | Go to diff View file |
M | plugins/agiledashboard/www/js/kanban/src/app/app-kanban-controller.js | +0 | −47 | Go to diff View file |
M | plugins/agiledashboard/www/js/kanban/src/app/app.js | +0 | −2 | Go to diff View file |
A | plugins/agiledashboard/www/js/kanban/src/app/kanban-column/kanban-column-identifier.js | +5 | −0 | Go to diff View file |
M | plugins/agiledashboard/www/js/kanban/src/app/kanban-column/kanban-column.tpl.html | +0 | −1 | Go to diff View file |
M | plugins/agiledashboard/www/js/kanban/src/app/kanban-item/kanban-item.js | +7 | −4 | Go to diff View file |
M | plugins/agiledashboard/www/js/kanban/src/app/kanban-item/kanban-item.tpl.html | +2 | −7 | Go to diff View file |
A | plugins/agiledashboard/www/js/kanban/src/app/kanban-item/time-info/time-info-component.js | +55 | −0 | Go to diff View file |
M | plugins/agiledashboard/www/js/kanban/src/app/socket/socket.js | +0 | −2 | Go to diff View file |
M | plugins/agiledashboard/www/themes/BurningParrot/css/kanban/_kanban-item.scss | +11 | −15 | Go to diff View file |