stable

Clone or download

Read-only

Scalar fields & fields value DAO in dedicated namespace

I made a first version of this patch that was very dumb. I was just converting _ into \ with appropriate rename/move to folders. However this lead to headaches for both PHPStorm and phpunit (so to me) because we ended to have stuff like FloatDao that where in 2 different namepaces Field/FloatDao and Field/Value/FloatDao. It was barely readable and tbh worst than the _ based namespace. This second attempt tries to be a bit more smart by grouping together things that "belongs" to the same field. I made it for scalar fields only so far as a demo (and because it's less invasive than for lists). The mass rename .class.php -> .php was made for all because it was easier to automate. I had to regenerate the psalm baseline from scratch because of all the moves. Part of request #17148 Tracker move to PSR4 😱 Change-Id: Idae50bd60993a23653c8f298441ac4c6d51c8b1a

Modified Files

Name
M plugins/tracker/include/Tracker/Artifact/dao/ComputedDao.php +2 −2 Go to diff View file
R plugins/tracker/include/Tracker/FormElement/dao/Tracker_FormElement_Field_DateDao.class.php Go to diff View file
R plugins/tracker/include/Tracker/FormElement/dao/Tracker_FormElement_Field_Value_DateDao.class.php Go to diff View file
R plugins/tracker/include/Tracker/FormElement/dao/Tracker_FormElement_Field_FloatDao.class.php Go to diff View file
R plugins/tracker/include/Tracker/FormElement/dao/Tracker_FormElement_Field_Value_FloatDao.class.php Go to diff View file
R plugins/tracker/include/Tracker/FormElement/dao/Tracker_FormElement_Field_IntegerDao.class.php Go to diff View file
R plugins/tracker/include/Tracker/FormElement/dao/Tracker_FormElement_Field_Value_IntegerDao.class.php Go to diff View file
R plugins/tracker/include/Tracker/FormElement/dao/Tracker_FormElement_Field_StringDao.class.php Go to diff View file
R plugins/tracker/include/Tracker/FormElement/dao/Tracker_FormElement_Field_TextDao.class.php Go to diff View file
R plugins/tracker/include/Tracker/FormElement/dao/Tracker_FormElement_Field_Value_TextDao.class.php Go to diff View file
R plugins/tracker/include/Tracker/FormElement/dao/Tracker_FormElement_SpecificPropertiesDao.class.php Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_Date.class.php +10 −8 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_Float.class.php +4 −2 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_Integer.class.php +4 −2 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_LastUpdateDate.class.php +2 −1 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_String.class.php +3 −2 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_SubmittedOn.class.php +2 −1 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_Text.class.php +4 −2 Go to diff View file
R plugins/tracker/include/Tracker/FormElement/dao/Tracker_FormElement_FieldDao.class.php Go to diff View file
R plugins/tracker/include/Tracker/FormElement/dao/Tracker_FormElement_Field_BurndownDao.class.php Go to diff View file
R plugins/tracker/include/Tracker/FormElement/dao/Tracker_FormElement_Field_ComputedDao.class.php Go to diff View file
R plugins/tracker/include/Tracker/FormElement/dao/Tracker_FormElement_Field_ComputedDaoCache.class.php Go to diff View file
R plugins/tracker/include/Tracker/FormElement/dao/Tracker_FormElement_Field_ListDao.class.php Go to diff View file
R plugins/tracker/include/Tracker/FormElement/dao/Tracker_FormElement_Field_List_BindDecoratorDao.class.php Go to diff View file
R plugins/tracker/include/Tracker/FormElement/dao/Tracker_FormElement_Field_List_Bind_DefaultvalueDao.class.php Go to diff View file
R plugins/tracker/include/Tracker/FormElement/dao/Tracker_FormElement_Field_List_Bind_StaticDao.class.php Go to diff View file
R plugins/tracker/include/Tracker/FormElement/dao/Tracker_FormElement_Field_List_Bind_Static_ValueDao.class.php Go to diff View file
R plugins/tracker/include/Tracker/FormElement/dao/Tracker_FormElement_Field_List_Bind_Ugroups_ValueDao.class.php Go to diff View file
R plugins/tracker/include/Tracker/FormElement/dao/Tracker_FormElement_Field_List_Bind_UsersDao.class.php Go to diff View file
R plugins/tracker/include/Tracker/FormElement/dao/Tracker_FormElement_Field_List_OpenValueDao.class.php Go to diff View file
R plugins/tracker/include/Tracker/FormElement/dao/Tracker_FormElement_Field_MultiSelectboxDao.class.php Go to diff View file
R plugins/tracker/include/Tracker/FormElement/dao/Tracker_FormElement_Field_OpenListDao.class.php Go to diff View file
R plugins/tracker/include/Tracker/FormElement/dao/Tracker_FormElement_Field_ValueDao.class.php Go to diff View file
R plugins/tracker/include/Tracker/FormElement/dao/Tracker_FormElement_Field_Value_ArtifactLinkDao.class.php Go to diff View file
R plugins/tracker/include/Tracker/FormElement/dao/Tracker_FormElement_Field_Value_FileDao.class.php Go to diff View file
R plugins/tracker/include/Tracker/FormElement/dao/Tracker_FormElement_Field_Value_ListDao.class.php Go to diff View file
R plugins/tracker/include/Tracker/FormElement/dao/Tracker_FormElement_Field_Value_NumericDao.class.php Go to diff View file
R plugins/tracker/include/Tracker/FormElement/dao/Tracker_FormElement_Field_Value_OpenListDao.class.php Go to diff View file
R plugins/tracker/include/Tracker/FormElement/dao/Tracker_FormElement_Field_Value_PermissionsOnArtifactDao.class.php Go to diff View file
R plugins/tracker/include/Tracker/FormElement/dao/Tracker_FormElement_StaticField_RichTextDao.class.php Go to diff View file
M plugins/tracker/tests/unit/Tracker/FormElement/Field/Numeric/Tracker_FormElement_Field_NumericTest.php +6 −2 Go to diff View file
M plugins/tracker/tests/unit/Tracker/FormElement/Tracker_FormElement_Field_DateTest.php +3 −3 Go to diff View file
M plugins/tracker/tests/unit/Tracker/FormElement/Tracker_FormElement_Field_FloatTest.php +3 −3 Go to diff View file
M plugins/tracker/tests/unit/Tracker/FormElement/Tracker_FormElement_Field_IntegerTest.php +5 −3 Go to diff View file
M plugins/tracker/tests/unit/Tracker/FormElement/Tracker_FormElement_Field_TextTest.php +3 −2 Go to diff View file
M tests/psalm/tuleap-baseline.xml +172 −213 Go to diff View file