stable
Clone or download
Read-only
request #12588 CssAssetCollection should be immutable
In order to ease future contributions to Widget CSS dependencies, CssAssetCollection should be immutable. How to test: - CSS files are still loaded in FlamingParrot and BurningParrot - Kanban widget's CSS file is still loaded. Change-Id: I792d2c5e938ae40c9362c9aa3b24f7441993f4bb
Modified Files
Name | ||||
---|---|---|---|---|
M | plugins/agiledashboard/include/AgileDashboard/Widget/Kanban.php | +2 | −5 | Go to diff View file |
M | src/common/Dashboard/AssetsIncluder.php | +6 | −3 | Go to diff View file |
M | src/common/layout/BaseLayout.php | +4 | −4 | Go to diff View file |
M | src/common/layout/CssAssetCollection.php | +16 | −5 | Go to diff View file |
M | src/common/widget/Widget.class.php | +1 | −1 | Go to diff View file |
M | tests/phpunit/common/Dashboard/AssetsIncluderTest.php | +4 | −4 | Go to diff View file |
M | tests/phpunit/common/Layout/CssAssetCollectionTest.php | +6 | −14 | Go to diff View file |