This is a part of story #8858 query tracker with expressions No functional changes. We must remove the contract definition in the Visitor. If we don't, then we will have to write: class A { public function accept(Visitor $v, VisitorParameters $p) { $v->visitA($this, $p); } } interface Visitor { public function visitA(A $a, VisitorParameters $p); } class VisitorXxx implements Visitor { public function visitA(A $a, VisitorParameters $p) { } } However in the implementation of visitA in VisitorXxx, we need a XxxParameters, not a VisitorParameters. we need to access to specific parameter. In one case it will be getUser() in another case it will be getFieldCollection(), … it depends on the context (context defined by the specific visitor. We cannot write this: class VisitorXxx implements Visitor { public function visitA(A $a, XxxParameters $p) { } } because 1) it breaks LSP and 2) PHP does not accept it since the declaration differs from the parent interface. The only way to manage this case is the following hack: interface Visitor { public function visitA(A $a); } class VisitorXxx implements Visitor { public function visitA(A $a, XxxParameters $p = null) { } } Here PHP will be happy, but the developer will not since null parameters are evil. This would mean that we will have to check the null case at runtime. (J)Hacky as hell. Therefore the only way to do so is to not anymore declare the functions in our interface. It is much preferable than the current situation where some parameters are used and some others are not. Change-Id: I6927152a35ac6230a0ae2eff60ba53dd41e13b05

+252 −99

Author

Nicolas Terray (nterray) 2017-01-02 15:21

Committer

Nicolas Terray (nterray) 2017-01-03 09:10

Hash 7fb4cd822734795074833df98b61c0b4d24ad642

Parent ca9b4abedd9dd63737074f5de4354c756bc656f3

Reference git #tuleap/stable/7fb4cd822734795074833df98b61c0b4d24ad642