Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Extract search report always there value in a unit tested dedicated object

Download Browse

part of story #24197 search for Documents with criteria No functional changes: You should still be able to use docman legacy advanced search Why this change: In order to have REST route folder/id/search I'll need to build a Docman_Report (as explained in AC, I will build and object arround DocmanItem_DAO::searchId in order to don't break the existing code) Docman_Reports come with two notions: - $filters (Docman_Filter) who will select properties on wich we search - $columns (Docman_ReportColumn) who will display the column we want to display in report results Extracting this behaviour in a dedicated object will enable me to reuse it and having it in a small object should prevent me to introduce breaking change in legacy UI Change-Id: Ie2c8e2f76e445eb60e999fa284837ae819e20be6

+108 −10
Marie Ange Garnier (marieange) 2022-01-10 11:35
Marie Ange Garnier (marieange) 2022-01-10 16:41
80e081cf6d207ec4bc9bb96cb4c697cd3d461bc3
56f2d5577a628e844018cf12ae15c2af9544caa7
git #tuleap/stable/80e081cf6d207ec4bc9bb96cb4c697cd3d461bc3

Modified Files

Side by side diff
Inline diff
Name
M plugins/docman/include/Docman_ReportFactory.class.php +6 −10 Go to diff View file
A plugins/docman/include/Search/AlwaysThereColumnRetriever.php +44 −0 Go to diff View file
A plugins/docman/tests/unit/Search/AlwaysThereColumnRetrieverTest.php +58 −0 Go to diff View file