Part of request #11719 File upload with the artifact modal freezes the browser This adresses the problem of browser freezing just after choosing a file in the artifact modal. To unfreeze the browser, a few steps are needed: - Remove the broken angular-base64-upload component. As soon as a file was chosen, it tried to load it in memory all at once and then encode it into base64. As you can imagine, on bigger files (say 300MB) this would cause the browser to freeze and sometimes crash outright. - Reimplement a small directive to bind to ng-model. Somehow this isn't provided by AngularJS :/ - Reimplement file reading, encoding and uploading with streams [1]. - Rework error handling to show a relevant, localized error message instead of HTTP code and messages that do not help. How to test: - Edit an existing artifact with a file field, attach files to it and submit. Upon submit, the file should be send as many fetch() requests to temporary files and then be attached to the artifact. - Try with a file size below 1MB (chunk size) - Try with a file size above 1MB (multiple chunks) - Try with a file size above your quota (defined in local.inc). An error message should be shown. (See below notes). The quota progress bar should be filled up. - Try with multiple files in a single field (With the "Add another file" button) - Try with empty file inputs (where you click "Add another file" but don't choose anything or choose a file and hit "Reset"). Empty inputs should be silently ignored. - Try with two file fields - Submit a new artifact with files - Check that it works on Chrome, Firefox and IE11 - Check that it works in Planning, Kanban and TTM Note: Warning the user that they're about to upload a file that is bigger than their allowed quota will come in a later patch. For now, it tries to upload anyway, fills the quota and then shows an error message. Note: I know, I reduced test coverage, but I think unit testing streams can come later. [1]: https://nodejs.org/api/stream.html Note: I first attempted to use WHATWG streams [2][3], but the available polyfills did not function with IE11. Besides it is maybe too cutting-edge yet :p [2]: https://streams.spec.whatwg.org/ [3]: https://gerrit.tuleap.net/#/c/tuleap/+/11832/ Change-Id: I49ca8341ec88c01245079d9747188c54e189ed0e

+536 −578

Author

Joris MASSON (jmasson) 2018-06-29 14:13

Committer

Joris MASSON (jmasson) 2018-06-29 15:30

Hash 823eb0129fc72a454203708829d68dc39b7e1627

Parent 249eb8f7b22cf2be84b16a96a66a66553f6859db

Reference git #tuleap/stable/823eb0129fc72a454203708829d68dc39b7e1627