Fixes request #40086 JavaScript error when trying an expert query with default mode How to test: - In a Cross-tracker search widget, set up a query in expert mode and save the report. - Switch to default mode, select at least one tracker, do not edit the expert query (leave the SELECT ...). Click on "Search". - The widget should show a translated error message explaining that the "SELECT" keyword is not allowed in default mode. There is no JavaScript error in the console. No functional change excpected for the following errors: - Query is too complicated: change the limit to 1 in the DB, in tracker_report_config table - Too many SELECT fields: tuleap config-set crosstracker_maximum_selected_columns 1, use more than one field in SELECT - SELECT field used more than once: SELECT @id, @id - XTS syntax in tracker report: paste a valid expert query in a Tracker report - Missing FROM: it looks impossible to trigger, the parser will cause a SyntaxError before we reach it. Why? We do not try to use SyntaxError: we are not in a parser, we have no clue what the query string looks like. Instead of trying, we use regular exception to carry the error message. It should be helpful enough without. Exception translations are moved to a dedicated class. It keeps the advantage of having them only in one place, but it removes the responsibility of translation from the Exception classes. They are meant to help programmers, the calling code has the necessary context to know how (or even if) to translate them, or to format them (CSV plain-text or JSON). We did not change all exceptions handled, some of them are collections of messages. It's a start. Notes InvalidSelectablesCollectionBuilder (in Tracker) was never used. Change-Id: I58344a049032ed8da29b58ba8555a7a7f9ce728c

+257 −253

Author

Joris MASSON (jmasson) 2024-10-17 11:59

Committer

Joris MASSON (jmasson) 2024-10-18 17:33

Hash 825e4df7b1c256fd42d6f0d2e415a5f46753f8a6

Parent ef48fd2c61a83a58de4a182373500588e796986c

Reference git #tuleap/stable/825e4df7b1c256fd42d6f0d2e415a5f46753f8a6