Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: GroupCreatorTest should be a sociable test

Download Browse

Part of story #26799 associate a Tuleap project and a GitLab group No functional change. Interfaces are good but for high-level classes like GroupCreator, it's nice to be able to test all its execution, including its dependencies. It's "sort-of" an integration test, except all the API calls and DB are stubbed. The rest of the logic stays the same. It can help check that we did not break things when refactoring the inner dependencies. Change-Id: I17508330e779f6348288982b7fc04d9101829b51

+238 −204
Joris MASSON (jmasson) 2022-09-12 12:17
Joris MASSON (jmasson) 2022-09-13 08:47
82b6ee64c00869a94ae6c321dd438cf714ef1341
1aff74512d65b0cb78a4a9943cecaa3af3c2b105
git #tuleap/stable/82b6ee64c00869a94ae6c321dd438cf714ef1341

Modified Files

Side by side diff
Inline diff
Name
M plugins/gitlab/include/Group/GroupCreator.php +2 −2 Go to diff View file
M plugins/gitlab/include/Repository/GitlabRepositoryGroupLinkHandler.php +1 −1 Go to diff View file
D plugins/gitlab/include/Repository/HandleGitlabRepositoryGroupLink.php +0 −52 Go to diff View file
M plugins/gitlab/tests/unit/Group/GitlabRepositoryGroupLinkHandlerTest.php +9 −21 Go to diff View file
M plugins/gitlab/tests/unit/Group/GroupCreatorTest.php +90 −57 Go to diff View file
A plugins/gitlab/tests/unit/Test/Builder/GitlabProjectBuilder.php +56 −0 Go to diff View file
A plugins/gitlab/tests/unit/Test/Builder/RepositoryIntegrationBuilder.php +75 −0 Go to diff View file
M plugins/gitlab/tests/unit/Test/Stubs/BuildGitlabProjectsStub.php +5 −2 Go to diff View file
D plugins/gitlab/tests/unit/Test/Stubs/HandleGitlabRepositoryGroupLinkStub.php +0 −69 Go to diff View file