Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Chart displayers must not mutate it's props

Download Browse

part of request #33654 move project milestone widget in vue3 No functional changes: BurnDown, burnUp and TTM pie chart should still be displayed Note: Mutating Props is a vue anti-pattern [0], I have an eslint error when I'm converting the component into composition API I extracted the mutating props in a dedicated patch in order to help review I have remove the cache for graphs, it does not work on master it's a bug who will be corrected by request #35161 once the App will be fully migrated [0] https://vuejs.org/guide/components/props.html#one-way-data-flow Change-Id: Icac741b75cfdebc71e533576c62587f8e62ece3d

+373 −448
Marie Ange Garnier (marieange) 2023-11-16 12:03
Marie Ange Garnier (marieange) 2023-12-05 15:44
8663893874c085bde452c781bea2ed45b69ae650
a3ea496552ad3a0f04c4fb1c97c7972d4093fd4e
git #tuleap/stable/8663893874c085bde452c781bea2ed45b69ae650

Modified Files

Side by side diff
Inline diff
Name
M plugins/projectmilestones/scripts/projectmilestones/src/components/WhatsHotSection/ReleaseDescription/Chart/Burndown/Burndown.test.ts +1 −0 Go to diff View file
M plugins/projectmilestones/scripts/projectmilestones/src/components/WhatsHotSection/ReleaseDescription/Chart/Burndown/Burndown.vue +5 −3 Go to diff View file
M plugins/projectmilestones/scripts/projectmilestones/src/components/WhatsHotSection/ReleaseDescription/Chart/Burndown/BurndownDisplayer.test.ts +127 −180 Go to diff View file
M plugins/projectmilestones/scripts/projectmilestones/src/components/WhatsHotSection/ReleaseDescription/Chart/Burndown/BurndownDisplayer.vue +8 −9 Go to diff View file
M plugins/projectmilestones/scripts/projectmilestones/src/components/WhatsHotSection/ReleaseDescription/Chart/Burnup/Burnup.test.ts +1 −0 Go to diff View file
M plugins/projectmilestones/scripts/projectmilestones/src/components/WhatsHotSection/ReleaseDescription/Chart/Burnup/Burnup.vue +5 −3 Go to diff View file
M plugins/projectmilestones/scripts/projectmilestones/src/components/WhatsHotSection/ReleaseDescription/Chart/Burnup/BurnupDisplayer.test.ts +145 −199 Go to diff View file
M plugins/projectmilestones/scripts/projectmilestones/src/components/WhatsHotSection/ReleaseDescription/Chart/Burnup/BurnupDisplayer.vue +8 −9 Go to diff View file
M plugins/projectmilestones/scripts/projectmilestones/src/components/WhatsHotSection/ReleaseDescription/Chart/ChartDisplayer.test.ts +26 −2 Go to diff View file
M plugins/projectmilestones/scripts/projectmilestones/src/components/WhatsHotSection/ReleaseDescription/Chart/ChartDisplayer.vue +26 −25 Go to diff View file
M plugins/projectmilestones/scripts/projectmilestones/src/components/WhatsHotSection/ReleaseDescription/TestManagement/TestManagement.vue +10 −8 Go to diff View file
M plugins/projectmilestones/scripts/projectmilestones/src/components/WhatsHotSection/ReleaseDescription/TestManagement/TestManagementDisplayer.vue +11 −10 Go to diff View file