Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: Migrate side-by-side-line-grouper to TypeScript

Download Browse

part of request #29602 Migrate pullrequest file-diffs to TypeScript [Bonus] The algorithm has been simplified. Before, we were mutating the file lines by adding them information regarding the group they belong. This property is only used to build the groups of lines, and it was pretty simple to get rid of it by fetching the last group constructed during the reduce function. -- No functional change expected Change-Id: Ibcef465ac0a94a11847e30ab3c3477e2947fc0a6

+220 −134
Thomas Gorka (tgorka) 2022-11-09 17:20
Thomas Gorka (tgorka) 2022-11-15 11:19
868aa37938367e49be9fbd0bdc60dde23a62ec6f
e92bd094a4b4265e5f3e61c22a5b58e85a80af55
git #tuleap/stable/868aa37938367e49be9fbd0bdc60dde23a62ec6f

Modified Files

Side by side diff
Inline diff
Name
M plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-code-placeholder-builder.js +1 −1 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-code-placeholder-builder.test.js +1 −1 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-comment-placeholder-builder.js +1 −1 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-comment-placeholder-builder.test.js +1 −1 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-diff-component.js +7 −1 Go to diff View file
D plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-line-grouper.js +0 −87 Go to diff View file
R plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-line-grouper.test.js Go to diff View file
A plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-line-grouper.ts +76 −0 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-line-mapper.js +1 −1 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-line-mapper.test.js +1 −1 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-lines-state.js +9 −6 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-lines-state.test.js +50 −32 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-placeholder-positioner.js +1 −1 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-placeholder-positioner.test.js +1 −1 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/types.ts +10 −0 Go to diff View file
A plugins/pullrequest/scripts/pullrequests-app/tests/stubs/GroupSideBySideLinesStub.ts +60 −0 Go to diff View file