stable

Clone or download

Read-only

Remove unneeded object LockUpdater and rely on core behaviour

part of story #12454 Lock documents PATCH routes relies on wrong mechanism, we should not try to be smart and directly rely on core: - When you update an element and lock/unlock files then it should log and event in document history Change-Id: Id5135303470df29fe0f65dd54d7800e76be1a608

Modified Files

Name
M plugins/docman/include/Docman_Actions.class.php +6 −47 Go to diff View file
M plugins/docman/include/Docman_ActionsDeleteVisitor.class.php +1 −1 Go to diff View file
M plugins/docman/include/Docman_ItemFactory.class.php +2 −2 Go to diff View file
M plugins/docman/include/Docman_LockFactory.class.php +64 −27 Go to diff View file
M plugins/docman/include/Docman_PermissionsManager.class.php +1 −1 Go to diff View file
D plugins/docman/include/Lock/LockUpdater.php +0 −54 Go to diff View file
M plugins/docman/include/Log/LogEventAdder.php +0 −2 Go to diff View file
M plugins/docman/include/REST/v1/DocmanFilesResource.php +8 −5 Go to diff View file
M plugins/docman/include/REST/v1/DocmanItemUpdator.php +13 −18 Go to diff View file
M plugins/docman/include/REST/v1/DocmanItemUpdatorBuilder.php +3 −2 Go to diff View file
M plugins/docman/include/REST/v1/DocmanItemsResource.php +1 −1 Go to diff View file
M plugins/docman/include/Upload/Version/VersionUploadFinisher.php +13 −9 Go to diff View file
M plugins/docman/include/docmanPlugin.class.php +10 −3 Go to diff View file
A plugins/docman/phpunit/Docman_LockFactoryTest.php +97 −0 Go to diff View file
D plugins/docman/phpunit/Lock/LockUpdaterTest.php +0 −110 Go to diff View file
M plugins/docman/phpunit/Upload/Version/VersionUploadFinisherTest.php +8 −8 Go to diff View file