Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Add dedicated interface for User Stories visibility

Download Browse

part of story #21385 display Program's iterations No functional change expected in the following use cases: - GET the content of an Iteration - GET the content of a Program increment - GET the Program backlog Notes: "ArtifactIsVisible" is too generic. Artifact is a Tracker plugin concept, we should have specific interfaces for "Program Management" concepts such as Feature or User Story. The adapter does the same thing so it's ok if it implements a bunch of similar interfaces. I took the opportunity to simplify SearchChildrenOfFeature so it returns int[] instead of a DAO row array. It also takes a FeatureIdentifier instead of any int. I also took the opportunity to simplify FeatureHasUserStoriesVerifier, which was moved in the Domain since it only depends on Domain interfaces. Change-Id: Iaf7b3349803fac8dadd33a2dbab8f2056d77f67f

+302 −184
Joris MASSON (jmasson) 2021-12-16 11:59
Joris MASSON (jmasson) 2021-12-16 12:28
87031a69b82e0fbd1f724f58da4728649b5cb225
60f5fad9444776fc0d55f1cc1d388a08b51b7dc2
git #tuleap/stable/87031a69b82e0fbd1f724f58da4728649b5cb225

Modified Files

Side by side diff
Inline diff
Name
M plugins/program_management/include/Adapter/ArtifactVisibleVerifier.php +7 −1 Go to diff View file
M plugins/program_management/include/Adapter/Program/Feature/Links/ArtifactsLinkedToParentDao.php +21 −17 Go to diff View file
R plugins/program_management/include/Adapter/Program/Feature/Content/FeatureHasUserStoriesVerifier.php Go to diff View file
M plugins/program_management/include/Domain/Program/Backlog/Feature/Feature.php +2 −2 Go to diff View file
M plugins/program_management/include/Domain/Program/Backlog/Feature/FeatureIdentifier.php +3 −1 Go to diff View file
M plugins/program_management/include/Domain/Program/Backlog/Feature/Links/SearchChildrenOfFeature.php +4 −2 Go to diff View file
M plugins/program_management/include/Domain/Program/Backlog/Feature/Links/UserStoryRetriever.php +3 −3 Go to diff View file
M plugins/program_management/include/Domain/Program/Backlog/Iteration/Content/IterationContentSearcher.php +10 −11 Go to diff View file
M plugins/program_management/include/Domain/Program/Backlog/ProgramBacklogSearcher.php +2 −2 Go to diff View file
M plugins/program_management/include/Domain/Program/Backlog/ProgramIncrement/Content/ProgramIncrementContentSearcher.php +2 −2 Go to diff View file
M plugins/program_management/include/Domain/Program/Backlog/UserStory/UserStoryIdentifier.php +11 −10 Go to diff View file
R plugins/program_management/include/Domain/Program/Backlog/Feature/Content/VerifyFeatureHasAtLeastOneUserStory.php Go to diff View file
R plugins/program_management/include/Domain/Program/Backlog/UserStory/MirroredIterationIdentifierCollection.php Go to diff View file
M plugins/program_management/include/REST/v1/IterationResource.php +8 −5 Go to diff View file
M plugins/program_management/include/REST/v1/ProgramIncrementResource.php +2 −2 Go to diff View file
M plugins/program_management/include/REST/v1/ProjectResource.php +4 −3 Go to diff View file
M plugins/program_management/tests/unit/Adapter/ArtifactVisibleVerifierTest.php +19 −2 Go to diff View file
R plugins/program_management/tests/unit/Stub/VerifyFeatureHasAtLeastOneUserStoryStub.php Go to diff View file
M plugins/program_management/tests/unit/Builder/MirroredIterationIdentifierCollectionBuilder.php +6 −3 Go to diff View file
M plugins/program_management/tests/unit/Builder/UserStoryIdentifierBuilder.php +3 −3 Go to diff View file
R plugins/program_management/tests/unit/Adapter/Program/Feature/Content/FeatureHasUserStoriesVerifierTest.php Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/Feature/FeatureTest.php +2 −2 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/Feature/Links/UserStoryRetrieverTest.php +3 −5 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/Iteration/Content/IterationContentSearcherTest.php +5 −2 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/ProgramBacklogSearcherTest.php +2 −2 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/ProgramIncrement/Content/ProgramIncrementContentSearcherTest.php +2 −2 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/UserStory/UserStoryIdentifierTest.php +88 −92 Go to diff View file
M plugins/program_management/tests/unit/REST/v1/FeatureRepresentationTest.php +2 −2 Go to diff View file
M plugins/program_management/tests/unit/Stub/SearchChildrenOfFeatureStub.php +11 −4 Go to diff View file
M plugins/program_management/tests/unit/Stub/SearchUserStoryPlannedInIterationStub.php +21 −4 Go to diff View file
A plugins/program_management/tests/unit/Stub/VerifyUserStoryIsVisibleStub.php +59 −0 Go to diff View file