Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

cleanup: Duplicated call to reloadUgroupBindingInProject

Download Browse

In `ProjectMembersController::addUserToProject()` there is a call to `UGroupBinding::reloadUgroupBindingInProject()` but it has already been called earlier: ``` ProjectMembersController::addUserToProject() `- account_add_user_to_group() `- ProjectMemberAdderWithStatusCheckAndNotifications::addProjectMemberWithFeedback() `- AddProjectMember::addProjectMember() `- UGroupBinding::reloadUgroupBindingInProject() ``` IMHO there is no need to call it twice here. No functional changes. Discovered during story #30021: Invite buddies to my Tuleap project Change-Id: Idce92c11927fcecfeef1804bf038a5bf70b8a9f5

+0 −2
Nicolas Terray (nterray) 2023-02-08 17:12
Nicolas Terray (nterray) 2023-02-08 17:12
874d630863ab344554332488127f9e8b0033466f
9a93627dfd069ff755d1d7c9056b831e3865d4d1
git #tuleap/stable/874d630863ab344554332488127f9e8b0033466f

Modified Files

Side by side diff
Inline diff
Name
M src/common/Project/Admin/ProjectMembers/ProjectMembersController.php +0 −2 Go to diff View file