Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Check contributor title semantics before aggregator milestone creation

Download Browse

This is part of story #16124 [release management] ensure Aggregator release creation is possible How to test: - Setup aggregator and contributor projects - In a contributor project's top milestone tracker, unset the Title semantic. - When you browse the aggregator project's top backlog planning, you should NOT see the "Create milestone" button. - If you set back the Title semantic, the button should appear. Note to reviewer: I would have preferred not to use Exceptions, but in this case we will want to log what kind of error happened for debug purposes. I cannot simply return a null collection as this would lose some information on the precise error encountered. Therefore I used Exceptions. Change-Id: I89f7cf2fddb8f79ce7770e617e1a00f60321b1f2

+483 −95
Joris MASSON (jmasson) 2020-08-10 09:58
Joris MASSON (jmasson) 2020-08-10 12:37
87b8eb95cf48f87631d898004c6d25658de09274
b63599e5c3dc3fde498f94f264005795a3a55fa9
git #tuleap/stable/87b8eb95cf48f87631d898004c6d25658de09274

Modified Files

Side by side diff
Inline diff
Name
M plugins/multi_project_backlog/include/Aggregator/ContributorProjectsCollection.php +6 −1 Go to diff View file
M plugins/multi_project_backlog/include/Aggregator/Milestone/MilestoneCreatorChecker.php +28 −17 Go to diff View file
A plugins/multi_project_backlog/include/Aggregator/Milestone/MilestoneTrackerCollection.php +54 −0 Go to diff View file
A plugins/multi_project_backlog/include/Aggregator/Milestone/MilestoneTrackerCollectionBuilder.php +60 −0 Go to diff View file
A plugins/multi_project_backlog/include/Aggregator/Milestone/MilestoneTrackerRetrievalException.php +27 −0 Go to diff View file
A plugins/multi_project_backlog/include/Aggregator/Milestone/MissingRootPlanningException.php +31 −0 Go to diff View file
A plugins/multi_project_backlog/include/Aggregator/Milestone/NoMilestoneTrackerException.php +31 −0 Go to diff View file
M plugins/multi_project_backlog/include/multi_project_backlogPlugin.php +4 −1 Go to diff View file
A plugins/multi_project_backlog/tests/unit/Aggregator/ContributorProjectsCollectionTest.php +49 −0 Go to diff View file
M plugins/multi_project_backlog/tests/unit/Aggregator/Milestone/MilestoneCreatorCheckerTest.php +80 −76 Go to diff View file
A plugins/multi_project_backlog/tests/unit/Aggregator/Milestone/MilestoneTrackerCollectionBuilderTest.php +113 −0 Go to diff View file