stable

Clone or download

Read-only

Fix issues detected by Psalm introduced by recent developments in the docman plugin

The type annotation issue of Luracast\Restler\RestException has been fixed and the type has been added in the constructor signature. The few existing usages passing the HTTP status code with a string has been fixed to avoid any issues espacially when the strict mode is used. Part of story #13217: Display embedded content Change-Id: I79aefd719151471022308b95edd5aebb81477c6d

Modified Files

Name
M plugins/docman/bin/DocmanImport/XMLDocmanImport.class.php +5 −11 Go to diff View file
M plugins/docman/composer.json +4 −1 Go to diff View file
M plugins/docman/include/Docman_ItemFactory.class.php +3 −21 Go to diff View file
M plugins/docman/include/Docman_Metadata.class.php +6 −13 Go to diff View file
M plugins/docman/include/Docman_VersionFactory.class.php +2 −2 Go to diff View file
M plugins/docman/include/LegacyRestoreDocumentsController.php +1 −1 Go to diff View file
M plugins/docman/include/LegacySendMessageController.php +1 −0 Go to diff View file
M plugins/docman/include/REST/ResourcesInjector.php +4 −3 Go to diff View file
M plugins/docman/include/REST/v1/DocmanEmbeddedFilesResource.php +2 −0 Go to diff View file
M plugins/docman/include/REST/v1/DocmanFilesResource.php +3 −3 Go to diff View file
M plugins/docman/include/REST/v1/DocmanFoldersResource.php +1 −1 Go to diff View file
M plugins/docman/include/REST/v1/DocmanItemCreator.php +1 −1 Go to diff View file
M plugins/docman/include/REST/v1/DocmanItemUpdator.php +1 −1 Go to diff View file
M plugins/docman/include/REST/v1/DocmanItemsResource.php +1 −1 Go to diff View file
M plugins/docman/include/REST/v1/DocmanLinksResource.php +1 −0 Go to diff View file
M plugins/docman/include/REST/v1/DocmanWikiResource.php +1 −0 Go to diff View file
M plugins/docman/include/REST/v1/EmbeddedFiles/DocmanEmbeddedFileUpdator.php +1 −1 Go to diff View file
M plugins/docman/include/REST/v1/Folders/ItemCanHaveSubItemsChecker.php +1 −1 Go to diff View file
M plugins/docman/include/REST/v1/Links/DocmanLinkPOSTRepresentation.php +2 −2 Go to diff View file
M plugins/docman/include/REST/v1/Links/DocmanLinkUpdator.php +1 −1 Go to diff View file
M plugins/docman/include/REST/v1/Metadata/MetadataRepresentation.php +1 −1 Go to diff View file
M plugins/docman/include/REST/v1/Wiki/DocmanWikiUpdator.php +1 −1 Go to diff View file
M plugins/docman/include/Upload/Version/VersionUploadFinisher.php +4 −2 Go to diff View file
M plugins/docman/include/constants.php +9 −1 Go to diff View file
M plugins/docman/include/docmanPlugin.class.php +2 −3 Go to diff View file
M plugins/document/include/documentPlugin.class.php +0 −3 Go to diff View file
M plugins/svn/include/REST/v1/RepositoryResource.php +6 −6 Go to diff View file
M plugins/tracker/include/REST/v1/ArtifactFilesResource.class.php +3 −3 Go to diff View file
M src/common/REST/I18NRestException.php +2 −3 Go to diff View file
M src/common/REST/JsonCast.class.php +3 −1 Go to diff View file
M src/common/REST/ProjectStatusVerificator.php +1 −1 Go to diff View file
M src/composer.json +1 −1 Go to diff View file
M src/composer.lock +8 −8 Go to diff View file