Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

chore: Let Git commands failures exceptions be logged

Download Browse

This is part of request #29608 Let Git commands failures exceptions be logged Given a Git command that ends in a non expected state (for example a failure in the command), then this error will generate an Exception. This exception must not be caught. It must ends with an error 500 and the exception will be logged in the rest_api_log and/or in the nginx/fpm error log. Git command failure must not occur. If it happen, we need to have details about the command and the failure. Change-Id: Ib10b8afdf29f05af1138503ff5a1edcfc37f85d3

+51 −89
Yannis ROSSETTO (rossettoy) 2022-11-12 15:10
Yannis ROSSETTO (rossettoy) 2022-11-14 14:53
890e6c71ae06d2ee48c92411cf6f5ec8dd48cdd3
761d439c579a35dc586c4ab0a2cab914acebae67
git #tuleap/stable/890e6c71ae06d2ee48c92411cf6f5ec8dd48cdd3

Modified Files

Side by side diff
Inline diff
Name
M plugins/git/include/Git_Exec.class.php +3 −0 Go to diff View file
D plugins/pullrequest/include/PullRequest/Exception/UnknownReferenceException.php +0 −31 Go to diff View file
M plugins/pullrequest/include/PullRequest/GitExec.php +15 −14 Go to diff View file
M plugins/pullrequest/include/PullRequest/REST/v1/PullRequestFileRepresentationFactory.php +3 −2 Go to diff View file
M plugins/pullrequest/include/PullRequest/REST/v1/PullRequestRepresentationFactory.php +3 −0 Go to diff View file
M plugins/pullrequest/include/PullRequest/REST/v1/PullRequestsResource.php +8 −18 Go to diff View file
M plugins/pullrequest/tests/unit/GitExecTest.php +19 −24 Go to diff View file