Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Refactoring rules validator second part

Download Browse

part of request #13691 This patch only brings better and modern code to tracker rules validation. No fonctional changes are expected. The goal of the entire refactoring is to have a better, more maintainable and more testable code for futures changes in tracker rule validation. Change-Id: I1b3a8cdc2c788ecc15fc41e3bc933ec0ccb7a8b6

+271 −190
Lorentz Romain (lorentzr) 2019-08-06 15:32
Lorentz Romain (lorentzr) 2019-08-07 10:03
89da6683fe032fc49b69d9d523df6d3c638f474e
0d5708e00c5df80061ef3af97434b45b8c258539
git #tuleap/stable/89da6683fe032fc49b69d9d523df6d3c638f474e

Modified Files

Side by side diff
Inline diff
Name
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field.class.php +2 −1 Go to diff View file
M plugins/tracker/include/Tracker/Rule/TrackerRulesListValidator.php +160 −117 Go to diff View file
M plugins/tracker/include/Tracker/Rule/Tracker_RulesManager.class.php +10 −2 Go to diff View file
M plugins/tracker/include/Workflow/WorkflowFactory.class.php +2 −1 Go to diff View file
M plugins/tracker/phpunit/Tracker/Rules/TrackerRulesListValidatorTest.php +60 −60 Go to diff View file
M plugins/tracker/tests/Tracker_RulesManagerTest.php +34 −8 Go to diff View file
M plugins/tracker/tests/workflow/WorkflowFactoryTest.php +3 −1 Go to diff View file