Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Refacto - Retrieve team trackers collection out of TimeboxCreatorChecker

Download Browse

This is part of story #21368 create mirrored iteration No functional changes. This patch move the recovery of Teams tracker in ProgramIncrementCreatorChecker because TimeboxCreatorChecker will be used in next patches by IterationCreatorChecker to check if an iteration will can be created. But since now, TimeboxCreatorChecker will retrieve only teams tracker of Program Increment (not iteration). How to test: - If you have right, you can still create a PI - If something is wrong (bad semantic, bad user right, ...) logs are logged Note to reviewer: - I add a logger in ProgramIncrementCreatorChecker to know which milestone type we deal with - TimeboxCreatorCheckerTest use PHPUnit instead of Mockery Change-Id: Id75306dc814a7393f44f8c74769f7727a863fe21

+318 −329
Benjamin Bouillot (ben.bouillot) 2021-06-04 11:08
Benjamin Bouillot (ben.bouillot) 2021-06-04 11:27
8a38471c82a560abfa50a03b2e443288f4e50a70
485e1f29e86256801a734e868c5b1aefbcf5e254
git #tuleap/stable/8a38471c82a560abfa50a03b2e443288f4e50a70

Modified Files

Side by side diff
Inline diff
Name
M plugins/program_management/include/Domain/Program/Backlog/CreationCheck/ProgramIncrementCreatorChecker.php +51 −4 Go to diff View file
M plugins/program_management/include/Domain/Program/Backlog/CreationCheck/TimeboxCreatorChecker.php +14 −71 Go to diff View file
M plugins/program_management/include/program_managementPlugin.php +13 −11 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/CreationCheck/ProgramIncrementCreatorCheckerTest.php +131 −26 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/CreationCheck/TimeboxCreatorCheckerTest.php +109 −217 Go to diff View file