Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

fix request #30019 Artifact modal must wait for artifact links to be loaded

Download Browse

- When editing an artifact, while the linked artifacts are loading, the Submit button should be disabled with a title attribute explaining why. - When they finish loading, the button should be enabled again. - If the REST call is in error, the button should stay disabled. - When creating a new artifact or when there is no artifact link field, the Submit button should stay enabled (no functional change). Change-Id: I523bda0386784e2d25086b79ffabceecdd9ecf74

+197 −37
Joris MASSON (jmasson) 2022-12-29 10:55
Joris MASSON (jmasson) 2023-01-03 15:13
8ac3ffbb97334f328a6565c3e79a8ca186e7a94a
9be2eed76529f0ad699fd8e07b16ba08e200d0df
git #tuleap/stable/8ac3ffbb97334f328a6565c3e79a8ca186e7a94a

Modified Files

Side by side diff
Inline diff
Name
M plugins/tracker/scripts/lib/artifact-modal/po/fr_FR.po +5 −2 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/po/pt_BR.po +3 −0 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field/LinkFieldController.test.ts +34 −4 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field/LinkFieldController.ts +17 −7 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field/LinkedArtifactTemplate.test.ts +5 −3 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field/NewLinkTemplate.test.ts +5 −3 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field/TypeSelectorTemplate.test.ts +5 −3 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/domain/DidChangeListFieldValue.ts +1 −3 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/domain/DidCheckFileFieldIsPresent.ts +1 −3 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/domain/DomainEvent.ts +4 −0 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/domain/EventDispatcher.test.ts +5 −2 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/domain/fields/file-field/FileFieldController.ts +1 −2 Go to diff View file
A plugins/tracker/scripts/lib/artifact-modal/src/domain/submit/WillDisableSubmit.ts +29 −0 Go to diff View file
A plugins/tracker/scripts/lib/artifact-modal/src/domain/submit/WillEnableSubmit.ts +26 −0 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/gettext-catalog.ts +2 −0 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/tuleap-artifact-modal-controller.js +15 −4 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/tuleap-artifact-modal.tpl.html +2 −1 Go to diff View file
A plugins/tracker/scripts/lib/artifact-modal/tests/stubs/DispatchEventsStub.ts +37 −0 Go to diff View file