Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Do not display cross references of unreadable wiki pages

Download Browse

If wiki pages is not accessible to the current user, then we should not display their references in artifact cross references field. Note: due to direct call to db_query() in WikiPage constructor, it is not possible to add unit test to the new dedicated object that returns a WikiPage. Part of story #17180 take into account gitlab commits Change-Id: I6c418eae74a6adf29b329ab974f9fb1ee8f15f32

+398 −7
Nicolas Terray (nterray) 2020-12-28 11:26
Nicolas Terray (nterray) 2020-12-28 12:49
8c6c2fac1a6bbb58475b90084ce2ec0458d62601
b115e62397cf996d820012dfb889c9ade2f3b2de
git #tuleap/stable/8c6c2fac1a6bbb58475b90084ce2ec0458d62601

Modified Files

Side by side diff
Inline diff
Name
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_CrossReferences.php +11 −2 Go to diff View file
A src/common/Reference/ByNature/CrossReferenceByNatureInCoreOrganizer.php +49 −0 Go to diff View file
A src/common/Reference/ByNature/Wiki/CrossReferenceWikiOrganizer.php +72 −0 Go to diff View file
A src/common/Reference/ByNature/Wiki/WikiPageFromReferenceValueRetriever.php +46 −0 Go to diff View file
M src/common/Reference/CrossReferenceByDirectionPresenterBuilder.php +9 −1 Go to diff View file
A tests/unit/common/Reference/ByNature/CrossReferenceByNatureInCoreOrganizerTest.php +79 −0 Go to diff View file
A tests/unit/common/Reference/ByNature/Wiki/CrossReferenceWikiOrganizerTest.php +119 −0 Go to diff View file
M tests/unit/common/Reference/CrossReferenceByDirectionPresenterBuilderTest.php +13 −4 Go to diff View file