Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Refacto: Import builder in object class ProgramIncrementTracker

Download Browse

This is part of story #20111 change features priority No expected changes. You can test with adding tracker in Plan. This patch aims to use builder in the class instead of another object. This makes it possible to be sure that ProgramIncrementTracker is an existing tracker, because some verification are done before the instantiaton. Without this patch, we need to do some manually verification after/before/never instantiation. In future developments, it will not be forgotten to check that `tracker_id` does exist, before to create a ProgramIncrementTracker. Change-Id: I57eac4f1d1dddae7ec11349c9ade3a4eb1b0ccae

+102 −28
Benjamin Bouillot (ben.bouillot) 2021-04-26 11:21
Benjamin Bouillot (ben.bouillot) 2021-04-26 11:21
8cba824edcd22ee060e95ebf6485b459e28de0f9
7c1d106fc010f572c5cf49bd9023cad1799cf580
git #tuleap/stable/8cba824edcd22ee060e95ebf6485b459e28de0f9

Modified Files

Side by side diff
Inline diff
Name
M plugins/program_management/include/Adapter/Program/Tracker/ProgramTrackerAdapter.php +1 −12 Go to diff View file
M plugins/program_management/include/Program/Plan/BuildTracker.php +4 −4 Go to diff View file
M plugins/program_management/include/Program/Plan/PlanCreator.php +2 −1 Go to diff View file
M plugins/program_management/include/Program/Plan/ProgramIncrementTracker.php +16 −1 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Tracker/ProgramTrackerAdapterTest.php +4 −7 Go to diff View file
M plugins/program_management/tests/unit/Program/Plan/PlanCreatorTest.php +4 −3 Go to diff View file
A plugins/program_management/tests/unit/Program/Plan/ProgramIncrementTrackerTest.php +71 −0 Go to diff View file