part of story #38627 : Choice of a new Rich Text Editor With this contribution, users are allowed to edit an existing link (not cross-references) using an [edit] button inside the LinkPopover. When clicked, the popover enters edition mode: - It is now displayed on the right (left if not enough space) - It contains a form where you can edit the url and the title Regarding the architecture, I chose to embed the EditLinkFormElement into the LinkPopoverElement in order to avoid the pain to deal with elements replacements outside of hybrids. With this strategy, we can easily toggle the menu or the form at will. Note: We should probably think about putting things in common regarding the create/edit link popover in the toolbar and the edit link popover in the editor. However, I have the feeling that we should finish the LinkPopover implementation first and see at the end what can be actually put in common. How to test: - Pick up an editor containing a link (or create a link node) - Click on the link - Click on the pencil button inside the popover --> The form is displayed --> The fields are filled with the link url and title - Cancel the edition --> The form popover is no longer displayed --> The menu is displayed again - Click on the pencil button - Edit the url and the title - Save --> The link has been updated with the new url and title. The following step is to ensure we have the same behavior with the toolbar popover: - edit once again the link, but leave the title field blank --> The title has been replaced with the provided href Change-Id: I3b5a02662b22850f0cd83ebc37954c6a8ed7e864

+941 −90

Author

Thomas Gorka (tgorka) 2024-09-24 15:32

Committer

Thomas Gorka (tgorka) 2024-09-24 17:15

Hash 8cda29dc6e4ceead0914016b1e197bc477fc03ff

Parent 3e8c2114770ba191dce8bac30622ae2d129764f1

Reference git #tuleap/stable/8cda29dc6e4ceead0914016b1e197bc477fc03ff