Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

request #11186 When there are multiple labeled items widgets, some are not instantiated

Download Browse

Introduced by 7dc55532345bea4199508d9d2afa611c7202f8ee from yours truly. Iterating on a list of DOM elements while deleting from the list (which is what Vue does when mounting) causes the loop to skip one element. Therefore, half of the widgets don't show up. While I was there, I also removed the useless "locale" property. Current user locale is given for free by BurningParrot on the <body> element... Change-Id: I9ad70d34b13fd55481de9fbac370b5250228f520

+13 −17
Joris MASSON (jmasson) 2018-02-23 17:03
Joris MASSON (jmasson) 2018-02-23 17:03
90b836b0ce2c4401bd8af520b67ebcf255366e0a
b4546062e0457d99646e1a64fd34903ed8ceebad
git #tuleap/stable/90b836b0ce2c4401bd8af520b67ebcf255366e0a

Modified Files

Side by side diff
Inline diff
Name
M plugins/label/include/Label/Widget/ProjectLabeledItems.php +1 −2 Go to diff View file
M plugins/label/include/Label/Widget/ProjectLabeledItemsPresenter.php +1 −2 Go to diff View file
M plugins/label/templates/widgets/project-labeled-items.mustache +0 −1 Go to diff View file
M plugins/label/www/scripts/project-labeled-items/src/LabeledItemsList.vue +0 −3 Go to diff View file
M plugins/label/www/scripts/project-labeled-items/src/index.js +11 −9 Go to diff View file