stable
Clone or download
Read-only
part of request #17148 Tracker move to PSR4 😱 No functional change. Unit tests and Psalm should pass. Notes: Psalm was reporting a type mismatch error for a call to ChangesetTestBuilder::aChangeset(), so I chose to change the type everywhere to int (as it should be). When I wrote the builder, I used string because I had been burned by the DAO returning a string id. We should instead set-up our builders so they build correct data, the id should be int. Change-Id: Iaa39365bdac0b37fc0bfb1785ca3559d821bad3c
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/agiledashboard/tests/unit/AgileDashboard/ExplicitBacklog/DirectArtifactLinkCleanerTest.php | +3 | −3 | Go to diff View file |
| M | plugins/agiledashboard/tests/unit/AgileDashboard/FormElement/Burnup/CountElementsCalculatorTest.php | +16 | −16 | Go to diff View file |
| M | plugins/agiledashboard/tests/unit/AgileDashboard/FormElement/BurnupCalculatorTest.php | +4 | −4 | Go to diff View file |
| M | plugins/agiledashboard/tests/unit/AgileDashboard/Milestone/Sidebar/PromotedMilestoneBuilderTest.php | +1 | −1 | Go to diff View file |
| M | plugins/agiledashboard/tests/unit/AgileDashboard/Planning/MilestoneFactoryGetAllMilestonesTest.php | +4 | −4 | Go to diff View file |
| M | plugins/agiledashboard/tests/unit/AgileDashboard/Planning/MilestoneFactoryGetBareMilestoneByArtifactIdTest.php | +1 | −1 | Go to diff View file |
| M | plugins/agiledashboard/tests/unit/AgileDashboard/Planning/MilestoneFactoryGetMilestoneTest.php | +5 | −5 | Go to diff View file |
| M | plugins/agiledashboard/tests/unit/AgileDashboard/Planning/MilestoneFactoryGetPaginatedMilestonesTest.php | +1 | −1 | Go to diff View file |
| M | plugins/agiledashboard/tests/unit/AgileDashboard/Planning/MilestoneFactoryGetTopMilestonesTest.php | +3 | −3 | Go to diff View file |
| M | plugins/agiledashboard/tests/unit/AgileDashboard/Planning/MilestoneFactoryTest.php | +1 | −1 | Go to diff View file |
| M | plugins/agiledashboard/tests/unit/REST/v1/Scrum/BacklogItem/InitialEffortSemanticUpdaterTest.php | +1 | −1 | Go to diff View file |
| M | plugins/cardwall/tests/unit/CardwallConfigXmlImportTest.php | +4 | −4 | Go to diff View file |
| M | plugins/gitlab/tests/unit/Repository/Webhook/PostPush/PostPushWebhookCloseArtifactHandlerTest.php | +2 | −2 | Go to diff View file |
| M | plugins/program_management/tests/unit/Adapter/Events/ArtifactCreatedProxyTest.php | +1 | −1 | Go to diff View file |
| M | plugins/program_management/tests/unit/Adapter/Events/ArtifactUpdatedProxyTest.php | +2 | −2 | Go to diff View file |
| M | plugins/program_management/tests/unit/Adapter/Program/Backlog/AsynchronousCreation/LastChangesetRetrieverTest.php | +1 | −1 | Go to diff View file |
| M | plugins/program_management/tests/unit/Adapter/Program/Backlog/ProgramIncrement/Source/Changeset/SubmissionDateRetrieverTest.php | +1 | −1 | Go to diff View file |
| M | plugins/program_management/tests/unit/Adapter/Program/Backlog/ProgramIncrement/Source/Changeset/Values/DateValueRetrieverTest.php | +1 | −1 | Go to diff View file |
| M | plugins/program_management/tests/unit/Adapter/Program/Backlog/ProgramIncrement/Source/Changeset/Values/FieldValuesGathererTest.php | +1 | −1 | Go to diff View file |
| M | plugins/program_management/tests/unit/Adapter/Program/Backlog/Timebox/TimeframeValueRetrieverTest.php | +1 | −1 | Go to diff View file |
| M | plugins/program_management/tests/unit/Adapter/Program/Backlog/TopBacklog/Workflow/AddToTopBacklogPostActionTest.php | +2 | −2 | Go to diff View file |
| M | plugins/roadmap/tests/unit/Roadmap/REST/v1/RoadmapTasksRetrieverTest.php | +2 | −2 | Go to diff View file |
| M | plugins/roadmap/tests/unit/Roadmap/REST/v1/TaskRepresentationBuilderForTrackerTest.php | +1 | −1 | Go to diff View file |
| M | plugins/taskboard/tests/unit/Column/CardColumnFinderTest.php | +1 | −1 | Go to diff View file |
| M | plugins/taskboard/tests/unit/Column/FieldValuesToColumnMapping/ArtifactMappedFieldValueRetrieverTest.php | +3 | −3 | Go to diff View file |
| M | plugins/taskboard/tests/unit/REST/v1/Cell/CardMappedFieldUpdaterTest.php | +2 | −2 | Go to diff View file |
| M | plugins/tracker/tests/unit/Artifact/Changeset/AfterNewChangesetHandlerTest.php | +2 | −2 | Go to diff View file |
| M | plugins/tracker/tests/unit/Artifact/Changeset/CommentOnlyChangesetCreatorTest.php | +1 | −1 | Go to diff View file |
| M | plugins/tracker/tests/unit/Artifact/Changeset/NewChangesetPostProcessorTest.php | +1 | −1 | Go to diff View file |
| M | plugins/tracker/tests/unit/Artifact/Changeset/PostCreation/ActionsRunnerTest.php | +4 | −4 | Go to diff View file |
| M | plugins/tracker/tests/unit/Artifact/Changeset/PostCreation/CalendarEvent/EventDatesRetrieverTest.php | +1 | −1 | Go to diff View file |
| M | plugins/tracker/tests/unit/Artifact/Changeset/PostCreation/CalendarEvent/EventDescriptionRetrieverTest.php | +1 | −1 | Go to diff View file |
| M | plugins/tracker/tests/unit/Artifact/Changeset/PostCreation/CalendarEvent/EventOrganizerRetrieverTest.php | +2 | −2 | Go to diff View file |
| M | plugins/tracker/tests/unit/Artifact/Changeset/PostCreation/CalendarEvent/EventSummaryRetrieverTest.php | +1 | −1 | Go to diff View file |
| M | plugins/tracker/tests/unit/Artifact/Changeset/PostCreation/EmailNotificationAttachmentProviderTest.php | +1 | −1 | Go to diff View file |
| M | plugins/tracker/tests/unit/Artifact/ChangesetValue/ArtifactLink/ArtifactForwardLinksRetrieverTest.php | +3 | −3 | Go to diff View file |
| M | plugins/tracker/tests/unit/Artifact/ChangesetValue/ArtifactLink/ReverseLinksRetrieverTest.php | +3 | −1 | Go to diff View file |
| M | plugins/tracker/tests/unit/Artifact/ChangesetValue/ArtifactLink/ReverseLinksToNewChangesetsConverterTest.php | +6 | −4 | Go to diff View file |
| M | plugins/tracker/tests/unit/Artifact/ChangesetValue/ArtifactLink/StoredReverseLinkTest.php | +2 | −0 | Go to diff View file |
| M | plugins/tracker/tests/unit/Artifact/ChangesetValue/ChangesetValueSaverIgnoringPermissionsTest.php | +1 | −1 | Go to diff View file |
| M | plugins/tracker/tests/unit/Artifact/ChangesetValue/ChangesetValueSaverTest.php | +1 | −1 | Go to diff View file |
| M | plugins/tracker/tests/unit/Artifact/ChangesetValue/Text/TextValueInterpreterTest.php | +1 | −1 | Go to diff View file |
| M | plugins/tracker/tests/unit/Artifact/Closure/ArtifactCloserTest.php | +2 | −2 | Go to diff View file |
| M | plugins/tracker/tests/unit/Artifact/Closure/ArtifactClosingReferencesHandlerTest.php | +2 | −2 | Go to diff View file |
| M | plugins/tracker/tests/unit/Artifact/Link/ArtifactLinkerTest.php | +1 | −1 | Go to diff View file |
| M | plugins/tracker/tests/unit/Artifact/Link/ArtifactReverseLinksUpdaterTest.php | +1 | −1 | Go to diff View file |
| M | plugins/tracker/tests/unit/Artifact/StatusBadgeBuilderTest.php | +3 | −3 | Go to diff View file |
| M | plugins/tracker/tests/unit/Masschange/MasschangeUpdaterTest.php | +5 | −5 | Go to diff View file |
| M | plugins/tracker/tests/unit/Notifications/Recipient/MentionedUserInCommentRetrieverTest.php | +2 | −2 | Go to diff View file |
| M | plugins/tracker/tests/unit/Notifications/RemoveRecipient/RemoveRecipientThatAreTechnicalUsersTest.php | +1 | −1 | Go to diff View file |
| M | plugins/tracker/tests/unit/Notifications/RemoveRecipient/RemoveRecipientThatCannotReadAnythingTest.php | +4 | −4 | Go to diff View file |
| M | plugins/tracker/tests/unit/Notifications/RemoveRecipient/RemoveRecipientThatDoesntWantMailForTheirOwnActionsTest.php | +4 | −4 | Go to diff View file |
| M | plugins/tracker/tests/unit/Notifications/RemoveRecipient/RemoveRecipientWhenTheyAreInStatusUpdateOnlyModeTest.php | +1 | −1 | Go to diff View file |
| M | plugins/tracker/tests/unit/REST/Artifact/PUTHandlerTest.php | +1 | −1 | Go to diff View file |
| M | plugins/tracker/tests/unit/Semantic/Timeframe/TimeframeChangesetFieldsValueRetrieverTest.php | +1 | −1 | Go to diff View file |
| M | plugins/tracker/tests/unit/Semantic/Timeframe/TimeframeWithDurationTest.php | +4 | −4 | Go to diff View file |
| M | plugins/tracker/tests/unit/Semantic/Timeframe/TimeframeWithEndDateTest.php | +4 | −4 | Go to diff View file |
| M | plugins/tracker/tests/unit/Semantic/Tooltip/OtherSemantic/TimeframeTooltipEntryTest.php | +5 | −5 | Go to diff View file |
| M | plugins/tracker/tests/unit/Test/Builders/ArtifactImportedMappingBuilder.php | +3 | −3 | Go to diff View file |
| M | plugins/tracker/tests/unit/Test/Builders/ArtifactTestBuilder.php | +2 | −2 | Go to diff View file |
| M | plugins/tracker/tests/unit/Test/Builders/ArtifactValuesRepresentationBuilder.php | +4 | −5 | Go to diff View file |
| M | plugins/tracker/tests/unit/Test/Builders/ChangesetCommentTestBuilder.php | +1 | −1 | Go to diff View file |
| M | plugins/tracker/tests/unit/Test/Builders/ChangesetTestBuilder.php | +2 | −5 | Go to diff View file |
| M | plugins/tracker/tests/unit/Test/Builders/Fields/CheckboxFieldBuilder.php | +3 | −3 | Go to diff View file |
| M | plugins/tracker/tests/unit/Test/Builders/Fields/DateFieldBuilder.php | +3 | −3 | Go to diff View file |
| M | plugins/tracker/tests/unit/Test/Builders/Fields/ExternalFieldBuilder.php | +59 | −0 | Go to diff View file |
| M | plugins/tracker/tests/unit/Test/Builders/Fields/FileFieldBuilder.php | +3 | −3 | Go to diff View file |
| M | plugins/tracker/tests/unit/Test/Builders/Fields/ListFieldBuilder.php | +3 | −3 | Go to diff View file |
| M | plugins/tracker/tests/unit/Test/Builders/Fields/OpenListFieldBuilder.php | +3 | −3 | Go to diff View file |
| M | plugins/tracker/tests/unit/Test/Builders/Fields/RadioButtonFieldBuilder.php | +3 | −3 | Go to diff View file |
| M | plugins/tracker/tests/unit/Test/Builders/Fields/StringFieldBuilder.php | +3 | −3 | Go to diff View file |
| M | plugins/tracker/tests/unit/Test/Builders/LinkWithDirectionRepresentationBuilder.php | +19 | −3 | Go to diff View file |
| M | plugins/tracker/tests/unit/Test/Builders/TrackerTestBuilder.php | +14 | −14 | Go to diff View file |
| M | plugins/tracker/tests/unit/Test/Stub/BindValueIdCollectionStub.php | +1 | −1 | Go to diff View file |
| M | plugins/tracker/tests/unit/Test/Stub/CheckBeforeMoveStub.php | +0 | −3 | Go to diff View file |
| M | plugins/tracker/tests/unit/Test/Stub/CreateNewChangesetStub.php | +8 | −1 | Go to diff View file |
| M | plugins/tracker/tests/unit/Test/Stub/MoveDryRunStub.php | +0 | −3 | Go to diff View file |
| M | plugins/tracker/tests/unit/Test/Stub/MoveRestArtifactStub.php | +4 | −7 | Go to diff View file |
| M | plugins/tracker/tests/unit/Test/Stub/NewParentLinkStub.php | +1 | −1 | Go to diff View file |
| M | plugins/tracker/tests/unit/Test/Stub/RetrieveAllUsableTypesInProjectStub.php | +7 | −4 | Go to diff View file |
| M | plugins/tracker/tests/unit/Test/Stub/Tracker/Artifact/Changeset/PostCreation/CalendarEvent/RetrieveEventDatesStub.php | +6 | −0 | Go to diff View file |
| M | plugins/tracker/tests/unit/Test/Stub/Tracker/Artifact/Changeset/PostCreation/CalendarEvent/RetrieveEventOrganizerStub.php | +3 | −0 | Go to diff View file |
| M | plugins/tracker/tests/unit/Test/Stub/Tracker/Artifact/Changeset/PostCreation/CalendarEvent/RetrieveEventSummaryStub.php | +3 | −0 | Go to diff View file |
| M | plugins/tracker/tests/unit/Test/Stub/Tracker/Artifact/Changeset/PostCreation/PostCreationActionsQueuerStub.php | +3 | −1 | Go to diff View file |
| M | plugins/tracker/tests/unit/Test/Stub/Tracker/Artifact/Changeset/ProcessChangesetPostCreationStub.php | +0 | −3 | Go to diff View file |
| M | plugins/tracker/tests/unit/Test/Stub/Tracker/FormElement/Field/ListFields/Bind/BindVisitorStub.php | +4 | −4 | Go to diff View file |
| M | plugins/tracker/tests/unit/Test/Stub/Tracker/Permission/RetrieveUserPermissionOnTrackersStub.php | +3 | −0 | Go to diff View file |
| M | plugins/tracker/tests/unit/Test/Stub/UpdateArtifactLinkXMLStub.php | +4 | −12 | Go to diff View file |
| M | plugins/tracker_functions/tests/unit/TrackerFunctions/CustomCodeExecutionTaskTest.php | +7 | −7 | Go to diff View file |
| M | plugins/tracker_functions/tests/unit/TrackerFunctions/Notification/BuildMessagesForAdminsTest.php | +1 | −1 | Go to diff View file |
| M | plugins/tracker_functions/tests/unit/TrackerFunctions/Notification/SendMessagesForAdminsTest.php | +1 | −1 | Go to diff View file |
| M | plugins/tracker_functions/tests/unit/TrackerFunctions/Notification/SendNotificationToTrackerAdministratorTest.php | +2 | −2 | Go to diff View file |
| M | tests/psalm/psalm.xml | +0 | −11 | Go to diff View file |
| M | tests/psalm/tuleap-baseline.xml | +0 | −313 | Go to diff View file |