Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: Extract NewInlineCommentFormWidget insertion part

Download Browse

part of request #29602 Migrate pullrequest file-diffs to TypeScript This contribution aims to extract the part where we insert NewInlineCommentFormWidget in code mirrors. Now we also have unit tests for the placeholder height recomputation mecanism each time a widget is added How to test: --> No functional change expected in both diff modes Change-Id: I2a00ddc4d66202f664c3123b630f5eb5a524feef

+480 −165
Thomas Gorka (tgorka) 2022-11-25 15:27
Thomas Gorka (tgorka) 2022-11-25 16:40
935845d33b863c1a85f5ead607d85e72ffa3da71
8ec96c23d4bd6cc351955d40b8039f6b2b43c245
git #tuleap/stable/935845d33b863c1a85f5ead607d85e72ffa3da71

Modified Files

Side by side diff
Inline diff
Name
M plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/file-line-widget-placement-helper.test.ts +19 −13 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/file-line-widget-placement-helper.ts +6 −4 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-code-mirror-widget-creator.test.ts +4 −4 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-code-mirror-widget-creator.ts +16 −26 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-code-mirror-widgets-creation-manager.test.ts +282 −17 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-code-mirror-widgets-creation-manager.ts +47 −0 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-diff-component.js +46 −94 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/types-codemirror-overriden.ts +10 −2 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/unidiff-component.js +5 −5 Go to diff View file
A plugins/pullrequest/scripts/pullrequests-app/tests/stubs/CreateNewInlineCommentFormWidgetStub.ts +45 −0 Go to diff View file