This contribution introduce the usage of rector[0] to automate refactorings. Instead of doing the tedious and error prone job of doing the conversion of addHook() calls to attributes, a rector rule does the transformation on our behalf. The transformation itself can be reviewed with the provided test file for the rule. SvnPlugin was bit tied up after the automated transformation because there are some changes that seemed a bit to hard to automate but easily done in IDE (like removing the comments after the method call or dealing with uses). Rector command can be run this way: ```bash ./src/vendor/bin/rector --config=tools/utils/rector.php process --clear-cache -- plugins/svn/include/svnPlugin.php ``` Not all transformations are covered yet (it only take hooks in __construct right now). Future contributions will improve the process. [0]: https://github.com/rectorphp/rector Part of: request #31113 Simplify hook listening for plugins Change-Id: I7e63e4d335386350d45c9c54a5b20fd579bccfb6

+804 −98

Author

Manuel Vacelet (vaceletm) 2023-03-07 16:38

Committer

Manuel Vacelet (vaceletm) 2023-03-10 11:43

Hash 93732496830a4d3d0610dd1e4eeea83894fe9c43

Parent fc73be6f4bc45bfdbac18b78205fc2d5d2af1b58

Reference git #tuleap/stable/93732496830a4d3d0610dd1e4eeea83894fe9c43