stable
Clone or download
Read-only
fix: request #40450 Missing error messages in core-platform-admin-banner
How to test: - Edit src/common/Platform/Banner/REST/v1/BannerResource.php and make it throw RestExceptions in the putBanner and deleteBanner functions. - Go to Site admin > Platform Banner page. Either write a new banner message, or uncheck the "Activate..." checkbox. - You should see an error feedback on top of the page, and it should contain the error message you wrote in the RestException. Why? Took the opportunity to replace tlp-fetch by fetch-result. This lets us use Result type for clearer error handling. It also properly handles the error json from the Response. Change-Id: I00b02c787fb723a34ccc07abc91672f97a024fc6
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | src/scripts/platform-admin-banner/package.json | +3 | −1 | Go to diff View file |
| M | src/scripts/platform-admin-banner/pnpm-lock.yaml | +13 | −3 | Go to diff View file |
| M | src/scripts/platform-admin-banner/src/api/rest-querier.test.ts | +39 | −20 | Go to diff View file |
| M | src/scripts/platform-admin-banner/src/api/rest-querier.ts | +12 | −19 | Go to diff View file |
| M | src/scripts/platform-admin-banner/src/components/App.test.ts | +11 | −6 | Go to diff View file |
| M | src/scripts/platform-admin-banner/src/components/App.vue | +10 | −16 | Go to diff View file |