stable
Clone or download
In a previous commit[1], I removed a miss usage of $keyword parameter that was always null[2]. After carful (I hope) review, it appears that the $keyword parameter is always null. Worst, it breaks the Bind signature because Tracker_FormElement_Field_List_Bind::getAllValues() is being called with an argument (in getValuesByKeyword) but the abstract method doesn't expect one. I didn't manage to fully understand where this come from, I guess it was a duplicate from tracker v3 equivalent code: ArtifactField::getFieldPredefinedValues() Part of: request #31598 (Multi)SelectBox field bound to large list of users (5k+) performance issue [1] 22aa0e183158ec9783f6315bd3f8f3c5daab74d7 [2] https://gerrit.tuleap.net/c/tuleap/+/28508/6/plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_List_Bind_Users.php#299 Change-Id: I2e51ff8bfce6d4639675248f54f93af6afbed1cc
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/tracker/include/Tracker/FormElement/Field/ListFields/Bind/BindListUserValueGetter.php | +11 | −30 | Go to diff View file |
| M | plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_List_Bind.php | +1 | −1 | Go to diff View file |
| M | plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_List_Bind_Users.php | +3 | −7 | Go to diff View file |
| M | plugins/tracker/tests/unit/Tracker/FormElement/Field/ListFields/Bind/BindListUserValueGetterTest.php | +8 | −13 | Go to diff View file |
| M | src/common/dao/UGroupUserDao.class.php | +3 | −3 | Go to diff View file |
| M | src/common/tracker/ArtifactField.class.php | +4 | −4 | Go to diff View file |
| M | src/www/project/admin/ugroup_utils.php | +7 | −14 | Go to diff View file |