stable
Clone or download
part of story #31091 Add the hybrid comment to manage comments Please note: - The spinner displayed while the comments are being loaded is temporary and will be replaced with skeletons looking like the hybrids component soon. - There is no empty state yet. A SVG illustration is supposed to be displayed, I've decided to do it in a dedicated commit to reduce the commit's size. - The handling and display of errors that can occur when a reply to a comment is saved will be done in a dedicated commit. How to test: - Have a pull-request with some global comments, file comments and events comments (you can abandon then reopen the PR to have some) - Enable the feature flag (feature_flag_allow_pullrequest_v2), then go to the overview tab --> A spinner is displayed while the comments are loading --> When comments have loaded, the threads are displayed: ---> Global comments are displayed as usual. ---> File comments are displayed as usual, their links point properly to the comments in the files. --> Event comments are displayed as usual and are translated. --> Threads are colored - When an error occurres while the comments are loading --> The error modal opens and show the error Change-Id: I18fcf48cd01f266fbb5155b8fdeb3768c7c6bdc9
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/pullrequest/scripts/lib/pullrequest-comments/package.json | +0 | −7 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequest-overview/package.json | +1 | −0 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequest-overview/pnpm-lock.yaml | +2 | −0 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequest-overview/po/fr_FR.po | +15 | −0 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequest-overview/src/api/tuleap-rest-querier.test.ts | +39 | −1 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequest-overview/src/api/tuleap-rest-querier.ts | +21 | −3 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequest-overview/src/components/OverviewPane.vue | +5 | −9 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequest-overview/src/components/ReadOnlyInfo/PullRequestAuthor.test.ts | +26 | −15 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequest-overview/src/components/ReadOnlyInfo/PullRequestAuthor.vue | +4 | −5 | Go to diff View file |
| A | plugins/pullrequest/scripts/pullrequest-overview/src/components/Threads/CommentPresenterBuilder.test.ts | +165 | −0 | Go to diff View file |
| A | plugins/pullrequest/scripts/pullrequest-overview/src/components/Threads/CommentPresenterBuilder.ts | +139 | −0 | Go to diff View file |
| A | plugins/pullrequest/scripts/pullrequest-overview/src/components/Threads/OverviewThreads.test.ts | +110 | −0 | Go to diff View file |
| A | plugins/pullrequest/scripts/pullrequest-overview/src/components/Threads/OverviewThreads.vue | +158 | −0 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequest-overview/src/constants.ts | +7 | −1 | Go to diff View file |
| A | plugins/pullrequest/scripts/pullrequest-overview/src/helpers/relative-dates-helper.ts | +36 | −0 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequest-overview/src/pullrequest-overview.ts | +7 | −0 | Go to diff View file |
| M | plugins/pullrequest/templates/angular-pullrequest.mustache | +1 | −0 | Go to diff View file |