Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

chore(svn): Build REST SVN Settings in a dedicated object

Download Browse

This refactoring aims to remove the double validations of data done for Settings comming to REST data. In this first step, we move the building of the object in a dedicated unit tested class. In a second step, we will move all the checks done in SettingsRepresentationValidator directly in the builder to remove the double verifications. This is a followup of request #35495 Do not allow suspended or deleted user in REST SVN notifications No functionnal change expected. Change-Id: Id37e57895a9527564c98c0364dde6548070487a2

+537 −97
Yannis ROSSETTO (rossettoy) 2024-01-06 12:15
Yannis ROSSETTO (rossettoy) 2024-01-10 11:25
9954202f91ce6ef55a15495665e012c1342e3060
ba263968153d1c431f221ba3fbae8f3a436ffe4e
git #tuleap/stable/9954202f91ce6ef55a15495665e012c1342e3060

Modified Files

Side by side diff
Inline diff
Name
M plugins/svn/include/REST/v1/RepositoryResource.php +20 −78 Go to diff View file
M plugins/svn/include/SVN/Admin/ImmutableTag.php +19 −15 Go to diff View file
A plugins/svn/include/SVN/Repository/SettingsBuilder.php +151 −0 Go to diff View file
M plugins/svn/tests/unit/SVN/Repository/RepositoryCreatorTest.php +4 −4 Go to diff View file
A plugins/svn/tests/unit/SVN/Repository/SettingsBuilderTest.php +343 −0 Go to diff View file