stable
Clone or download
Read-only
Add back the recording of issues in the CI pipelines, Psalm now has the capability of generating reports with only the errors. This feature will also be useful to identify the files reporting issues when analyzed in isolation. This contribution also comes with the "fixes" for the issues found by this new version. Most of them are due to Psalm new capability to infer property types from simple constructors. Psalm 3.4.5 now longer stop the analysis of a block when an undefined function is found. As a result a lot of new deprecated functions has been found. The low risks functions has been updated, the ones with a non negligeable risks has been left as is and manually suppressed. Part of request #13292: Integrate vimeo/psalm to the test pipeline Change-Id: I526ef4344c73ea5631042a5895dac138a655ca8b
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/agiledashboard/include/AgileDashboard/REST/v2/BacklogItemRepresentation.php | +6 | −1 | Go to diff View file |
| M | plugins/docman/include/ApprovalTable/Reviewer/ReviewerFactory.class.php | +1 | −0 | Go to diff View file |
| M | plugins/docman/include/Docman_Actions.class.php | +1 | −0 | Go to diff View file |
| M | plugins/docman/include/Docman_HTTPController.class.php | +2 | −2 | Go to diff View file |
| M | plugins/docman/include/Docman_MetadataHtml.class.php | +1 | −1 | Go to diff View file |
| M | plugins/docman/include/Docman_PermissionsExport.class.php | +5 | −4 | Go to diff View file |
| M | plugins/docman/include/Docman_PermissionsManager.class.php | +1 | −0 | Go to diff View file |
| M | plugins/docman/include/Docman_PermissionsManagerDao.class.php | +1 | −0 | Go to diff View file |
| M | plugins/docman/include/Docman_Widget_MyDocman.class.php | +1 | −1 | Go to diff View file |
| M | plugins/docman/include/Docman_WikiController.class.php | +5 | −3 | Go to diff View file |
| M | plugins/docman/include/view/Docman_View_ItemDetailsSectionApproval.class.php | +6 | −6 | Go to diff View file |
| M | plugins/docman/include/view/Docman_View_ItemDetailsSectionNewVersion.class.php | +1 | −5 | Go to diff View file |
| M | plugins/docman/include/view/Docman_View_ItemDetailsSectionUpdate.class.php | +2 | −5 | Go to diff View file |
| M | plugins/docman/include/view/Docman_View_NewDocument.class.php | +19 | −10 | Go to diff View file |
| M | plugins/forumml/include/ForumML_HTMLPurifier.class.php | +6 | −5 | Go to diff View file |
| M | plugins/forumml/include/forumml_utils.php | +1 | −1 | Go to diff View file |
| M | plugins/git/include/Git/Driver/Gerrit/RemoteSSHCommand.class.php | +2 | −2 | Go to diff View file |
| M | plugins/git/include/Git/Mirror/MirrorDataMapper.class.php | +4 | −1 | Go to diff View file |
| M | plugins/git/include/GitPermissionsManager.class.php | +1 | −0 | Go to diff View file |
| M | plugins/graphontrackersv5/include/data-transformation/DataBuilderV5.class.php | +9 | −3 | Go to diff View file |
| M | plugins/ldap/include/LDAP_UserManager.class.php | +2 | −2 | Go to diff View file |
| M | plugins/mediawiki/include/MediawikiDataDir.php | +3 | −1 | Go to diff View file |
| M | plugins/mediawiki/include/MediawikiInstantiater.class.php | +1 | −3 | Go to diff View file |
| M | plugins/mediawiki/include/mediawikiPlugin.class.php | +0 | −12 | Go to diff View file |
| M | plugins/projectlinks/include/projectlinksPlugin.class.php | +2 | −2 | Go to diff View file |
| M | plugins/pullrequest/include/PullRequest/InlineComment/InlineCommentUpdater.php | +3 | −3 | Go to diff View file |
| M | plugins/pullrequest/include/PullRequest/PullRequestUpdater.php | +6 | −0 | Go to diff View file |
| M | plugins/svn/include/SVN/Commit/CommitInfoEnhancer.php | +3 | −3 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Action/CreateArtifact.class.php | +6 | −3 | Go to diff View file |
| M | plugins/tracker/include/Tracker/DateReminder/Tracker_DateReminderRenderer.class.php | +3 | −1 | Go to diff View file |
| M | plugins/tracker/include/Tracker/FormElement/Tracker_FormElement.class.php | +1 | −3 | Go to diff View file |
| M | plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_List_Bind_Users.class.php | +2 | −0 | Go to diff View file |
| M | plugins/tracker/include/Tracker/FormElement/View/Admin/Visitor.class.php | +2 | −1 | Go to diff View file |
| M | plugins/tracker/include/Tracker/FormElement/dao/Tracker_FormElement_Field_ComputedDaoCache.class.php | +1 | −10 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Tracker.class.php | +0 | −2 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Workflow/WorkflowTransitionController.php | +2 | −2 | Go to diff View file |
| M | plugins/tracker_date_reminder/include/TrackerDateReminder_ArtifactType.class.php | +1 | −1 | Go to diff View file |
| M | src/common/User/UserManager.class.php | +2 | −2 | Go to diff View file |
| M | src/common/Widget/Widget_MyLatestSvnCommits.class.php | +1 | −1 | Go to diff View file |
| M | src/common/Widget/Widget_MyMonitoredForums.class.php | +2 | −2 | Go to diff View file |
| M | src/common/Widget/Widget_MyMonitoredFp.class.php | +2 | −3 | Go to diff View file |
| M | src/common/Widget/Widget_ProjectLatestCommits.class.php | +2 | −2 | Go to diff View file |
| R | src/www/include/json.php | Go to diff View file | ||
| M | src/common/include/lib/PHP_BigFile.class.php | +2 | −9 | Go to diff View file |
| M | src/common/reference/ReferenceManager.class.php | +1 | −1 | Go to diff View file |
| M | src/common/tracker/HTML/ArtifactHtml.class.php | +2 | −2 | Go to diff View file |
| M | src/common/tracker/HTML/ArtifactTypeHtml.class.php | +3 | −2 | Go to diff View file |
| M | src/common/wiki/lib/Wiki.class.php | +2 | −1 | Go to diff View file |
| M | src/common/wiki/lib/WikiAttachment.class.php | +1 | −0 | Go to diff View file |
| M | src/common/wiki/phpwiki/lib/HtmlElement.php | +9 | −9 | Go to diff View file |
| M | src/composer.lock | +25 | −23 | Go to diff View file |
| M | src/core/goto.php | +1 | −1 | Go to diff View file |
| M | src/www/cvs/commit_utils.php | +4 | −3 | Go to diff View file |
| M | src/www/file/admin/frsajax.php | +4 | −5 | Go to diff View file |
| M | src/www/include/database.php | +5 | −0 | Go to diff View file |
| M | src/www/include/html.php | +1 | −2 | Go to diff View file |
| M | src/www/include/utils.php | +0 | −40 | Go to diff View file |
| M | src/www/project/admin/permission_request.php | +2 | −1 | Go to diff View file |
| M | src/www/project/admin/permissions.php | +2 | −0 | Go to diff View file |
| M | src/www/project/admin/ugroup_utils.php | +2 | −12 | Go to diff View file |
| M | src/www/project/export/user_groups_export.php | +1 | −0 | Go to diff View file |
| M | src/www/soap/tracker/tracker.php | +1 | −1 | Go to diff View file |
| M | src/www/svn/svn_utils.php | +2 | −0 | Go to diff View file |
| M | src/www/tracker/index.php | +4 | −4 | Go to diff View file |
| M | tests/Jenkinsfile | +1 | −0 | Go to diff View file |
| M | tests/Jenkinsfile-nightly | +1 | −0 | Go to diff View file |
| M | tests/actions.groovy | +1 | −1 | Go to diff View file |
| M | tests/lib/Psalm/PsalmCILauncher.php | +2 | −1 | Go to diff View file |
| M | tests/lib/Psalm/PsalmCommandLauncherWithIgnoreDirectory.php | +1 | −1 | Go to diff View file |
| R | tests/phpunit/www/include/JsonTest.php | Go to diff View file | ||
| M | tests/simpletest/common/frs/FRSXMLImporterTest.php | +2 | −2 | Go to diff View file |