stable
Clone or download
Read-only
Part of story #36833 search on semantics and always there fields even if not defined No functional change. CI should be happy. Why ? This finishes the refactoring of the structure of the query validation to transition away from checks being grouped by comparison type (equals, lesser than, etc). We want to group checks by semantic / field type instead, as it is easier to understand. Most of the time, we work "field by field", so it makes more sense to have all the business rules for a given field in as few files as possible, instead of having all the business rules for "equals" comparisons being grouped together. Furthermore, usage of inheritance makes it hard to keep a mental model of the validation rules for a given field. Change-Id: I32ec8b6d8e6db4521ee11d16ff1daee1b3063455
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/crosstracker/include/CrossTracker/REST/v1/CrossTrackerReportsResource.php | +5 | −28 | Go to diff View file |
| M | plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/AllowedMetadata.php | +0 | −11 | Go to diff View file |
| D | plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/QueryValidation/Comparison/Between/BetweenComparisonChecker.php | +0 | −59 | Go to diff View file |
| D | plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/QueryValidation/Comparison/ComparisonChecker.php | +0 | −113 | Go to diff View file |
| D | plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/QueryValidation/Comparison/Equal/EqualComparisonChecker.php | +0 | −46 | Go to diff View file |
| D | plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/QueryValidation/Comparison/GreaterOrLesserThanComparisonChecker.php | +0 | −62 | Go to diff View file |
| D | plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/QueryValidation/Comparison/GreaterThan/GreaterThanComparisonChecker.php | +0 | −33 | Go to diff View file |
| D | plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/QueryValidation/Comparison/GreaterThan/GreaterThanOrEqualComparisonChecker.php | +0 | −33 | Go to diff View file |
| D | plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/QueryValidation/Comparison/In/InComparisonChecker.php | +0 | −42 | Go to diff View file |
| D | plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/QueryValidation/Comparison/LesserThan/LesserThanComparisonChecker.php | +0 | −33 | Go to diff View file |
| D | plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/QueryValidation/Comparison/LesserThan/LesserThanOrEqualComparisonChecker.php | +0 | −33 | Go to diff View file |
| D | plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/QueryValidation/Comparison/ListValueToEmptyStringComparisonException.php | +0 | −37 | Go to diff View file |
| D | plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/QueryValidation/Comparison/ListValueValidator.php | +0 | −45 | Go to diff View file |
| D | plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/QueryValidation/Comparison/NonExistentListValueException.php | +0 | −42 | Go to diff View file |
| D | plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/QueryValidation/Comparison/NotEqual/NotEqualComparisonChecker.php | +0 | −46 | Go to diff View file |
| D | plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/QueryValidation/Comparison/NotIn/NotInComparisonChecker.php | +0 | −42 | Go to diff View file |
| A | plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/QueryValidation/DateValuesCollection.php | +111 | −0 | Go to diff View file |
| R | plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/QueryValidation/Comparison/ListToEmptyStringException.php | Go to diff View file | ||
| R | plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/ListFields/ListComparisonToCurrentDateTimeFault.php | Go to diff View file | ||
| R | plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/ListFields/ListComparisonToStatusOpenFault.php | Go to diff View file | ||
| R | plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/ListFields/ListValuesCollection.php | Go to diff View file | ||
| M | plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/QueryValidation/Metadata/ArtifactSubmitterChecker.php | +6 | −6 | Go to diff View file |
| M | plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/QueryValidation/Metadata/AssignedToChecker.php | +6 | −6 | Go to diff View file |
| M | plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/QueryValidation/Metadata/FlatInvalidMetadataChecker.php | +2 | −38 | Go to diff View file |
| A | plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/QueryValidation/Metadata/SubmissionDateChecker.php | +105 | −0 | Go to diff View file |
| R | plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/ListFields/MyselfNotAllowedForAnonymousFault.php | Go to diff View file | ||
| M | plugins/crosstracker/include/crosstrackerPlugin.php | +5 | −28 | Go to diff View file |
| M | plugins/crosstracker/tests/integration/CrossTracker/Tests/Report/ArtifactReportFactoryInstantiator.php | +5 | −28 | Go to diff View file |
| M | plugins/crosstracker/tests/unit/CrossTracker/Report/Query/Advanced/InvalidTermCollectorVisitorTest.php | +2 | −27 | Go to diff View file |
| D | plugins/crosstracker/tests/unit/CrossTracker/Report/Query/Advanced/QueryValidation/Comparison/ListValueValidatorTest.php | +0 | −80 | Go to diff View file |
| A | plugins/crosstracker/tests/unit/CrossTracker/Report/Query/Advanced/QueryValidation/DateValuesCollectionTest.php | +148 | −0 | Go to diff View file |
| R | plugins/crosstracker/tests/unit/CrossTracker/Report/Query/Advanced/ListFields/ListValuesCollectionTest.php | Go to diff View file | ||
| A | plugins/crosstracker/tests/unit/CrossTracker/Report/Query/Advanced/QueryValidation/Metadata/SubmissionDateCheckerTest.php | +163 | −0 | Go to diff View file |
| M | plugins/crosstracker/tests/unit/CrossTracker/Tests/Builders/InvalidSearchableCollectorParametersBuilder.php | +13 | −12 | Go to diff View file |