Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

chore: Cover getFieldDataFromRESTValue with unit tests

Download Browse

In order to be more confident in next refactoring, we should ensure that this method is well covered. Extracting the method to a dedicated object was considered but would involve too much unwanted change. This forces us to introduce dummy method to set a dao to ease test, due to crappy initial design. Cleaning up this mess is not the main objective, at least we have more tests for next contributions. No functional changes are expected. Part of story #23042: have "parent" as type within artifacts links Change-Id: I7613c77c535e80c5f4a098e691045453a4171653

+235 −17
Nicolas Terray (nterray) 2021-11-17 16:40
Nicolas Terray (nterray) 2021-11-18 11:23
9cbdabb302d0ce491ec3a2b3f3b57e41846c9e63
000c7ee040631023ef192f533c8308599df0b936
git #tuleap/stable/9cbdabb302d0ce491ec3a2b3f3b57e41846c9e63

Modified Files

Side by side diff
Inline diff
Name
A plugins/tracker/include/Tracker/Artifact/ChangesetValue/ArtifactLink/ChangesetValueArtifactLinkDao.php +48 −0 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_ArtifactLink.php +22 −17 Go to diff View file
M plugins/tracker/tests/unit/Tracker/FormElement/Tracker_FormElement_Field_ArtifactLinkTest.php +165 −0 Go to diff View file