Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

chore: Remove constant based events from AD plugin

Download Browse

Non-class constant based events like `addHook(AGILEDASHBOARD_EXPORT_XML)` cannot be converted to attribute based events because there is no way to know if the constant exist. Therefore we have to convert to class constant first. No functional changes. Part of request #31547: Simplify hook listening for plugins Part 2 Change-Id: Ia686e89a05d67ef45ed70df9f461e4a99f8b6e8d

+122 −168
Nicolas Terray (nterray) 2023-04-28 13:44
Nicolas Terray (nterray) 2023-04-28 15:07
9cd823e5ef621ab35dea85b6af1f61ff4615b696
2c136dc55003d8fc1481cefb8f91054d87e533ec
git #tuleap/stable/9cd823e5ef621ab35dea85b6af1f61ff4615b696

Modified Files

Side by side diff
Inline diff
Name
M plugins/agiledashboard/include/AgileDashboard/Planning/Admin/PlanningEditionPresenterBuilder.php +1 −1 Go to diff View file
M plugins/agiledashboard/include/AgileDashboard/REST/v1/BacklogItemRepresentationFactory.class.php +10 −1 Go to diff View file
M plugins/agiledashboard/include/AgileDashboard/REST/v1/Kanban/ItemRepresentationBuilder.php +2 −1 Go to diff View file
M plugins/agiledashboard/include/AgileDashboard/REST/v1/Milestone/MilestoneRepresentationBuilder.php +11 −1 Go to diff View file
M plugins/agiledashboard/include/AgileDashboard/REST/v1/MilestoneResource.class.php +25 −11 Go to diff View file
M plugins/agiledashboard/include/AgileDashboard/REST/v2/BacklogItemRepresentationFactory.class.php +1 −1 Go to diff View file
M plugins/agiledashboard/include/AgileDashboard/XMLFullStructureExporter.php +4 −5 Go to diff View file
M plugins/agiledashboard/include/Planning/MilestoneSelectorController.class.php +12 −1 Go to diff View file
M plugins/agiledashboard/include/Planning/PlanningController.class.php +30 −3 Go to diff View file
M plugins/agiledashboard/include/agiledashboardPlugin.php +3 −1 Go to diff View file
M plugins/agiledashboard/include/constants.php +0 −111 Go to diff View file
M plugins/agiledashboard/tests/unit/AgileDashboard/Planning/Admin/PlanningEditionPresenterBuilderTest.php +1 −1 Go to diff View file
M plugins/agiledashboard/tests/unit/AgileDashboard/Planning/MilestoneSelectorControllerTest.php +1 −1 Go to diff View file
M plugins/agiledashboard/tests/unit/AgileDashboard/XMLFullStructureExporterTest.php +4 −2 Go to diff View file
M plugins/cardwall/include/cardwallPlugin.php +12 −18 Go to diff View file
M plugins/tracker/include/trackerPlugin.php +5 −9 Go to diff View file