Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

fix: Remove check of zip archive in finisher

Download Browse

Checking the file content has nothing to do with the upload of a file in the tus protocole. The current situation is not correct since the tus js client does not handle well the 400 that is raised if a file is not a zip archive (the error message is lost in the process, the retry is broken, …). To fix the situation we now move the check to the async worker. Part of story #36484 create a new project from an XML template Change-Id: I2a5123906b3ea7504cc27c100c0e976705e8154d

+50 −69
Nicolas Terray (nterray) 2024-03-26 10:02
Nicolas Terray (nterray) 2024-03-26 12:33
9d64c214de6dc056d88c67517d7c3670d93216bd
e19f4eaedda777d5fc35e99085a91c9ec454cc60
git #tuleap/stable/9d64c214de6dc056d88c67517d7c3670d93216bd

Modified Files

Side by side diff
Inline diff
Name
M src/common/Project/Registration/Template/Upload/ExtractArchiveAndCreateProject.php +8 −4 Go to diff View file
D src/common/Project/Registration/Template/Upload/Tus/FileIsNotAnArchiveException.php +0 −32 Go to diff View file
M src/common/Project/Registration/Template/Upload/Tus/ProjectFileUploadFinisher.php +0 −14 Go to diff View file
M tests/unit/common/Project/Registration/Template/Upload/ExtractArchiveAndCreateProjectTest.php +42 −0 Go to diff View file
M tests/unit/common/Project/Registration/Template/Upload/Tus/ProjectFileUploadFinisherTest.php +0 −19 Go to diff View file