Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Fix scroll and style issues when hovering a collapsed column

Download Browse

Part of story #14310 stop being bothered by the hidden add-in-place editor when I drag and drop some cards While dragging a card, when you drag over a collapsed column, no horizontal scrollbar should appear. The "hover" visual style should not flicker. This change also migrates mouse events to pointer events. Pointer events [0] handle more than mouse, they should offer better accessibility. There is still a known issue existing in master: When you drag over a collapsed column, the dropzone's height can flicker. It will be handled in a dedicated change. [0]: https://developer.mozilla.org/en-US/docs/Web/API/Pointer_events Change-Id: Ic8535ee58c0fb443294df6fa33ef1e0a94cb150c

+324 −88
Joris MASSON (jmasson) 2020-01-29 16:00
Joris MASSON (jmasson) 2020-01-30 14:29
9e0cc2377d2630bb1f51b53014f24ecd93f0bf7e
d81cbc4b11ad8f66b2dc317e4c5eb13a074d6411
git #tuleap/stable/9e0cc2377d2630bb1f51b53014f24ecd93f0bf7e

Modified Files

Side by side diff
Inline diff
Name
M plugins/taskboard/scripts/taskboard/src/components/TaskBoard/Body/Swimlane/Cell/DropContainerCell.test.ts +29 −11 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/components/TaskBoard/Body/Swimlane/Cell/DropContainerCell.vue +2 −2 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/components/TaskBoard/Body/Swimlane/Cell/InvalidMappingCell.test.ts +24 −10 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/components/TaskBoard/Body/Swimlane/Cell/InvalidMappingCell.vue +2 −2 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/components/TaskBoard/Body/Swimlane/Cell/hovering-state-for-collapsed-column-mixin.ts +14 −8 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/components/TaskBoard/Header/Collapsed/CollapsedLabel.test.ts +31 −13 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/components/TaskBoard/Header/Collapsed/CollapsedLabel.vue +2 −2 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/components/TaskBoard/TaskBoard.test.ts +118 −1 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/components/TaskBoard/TaskBoard.vue +10 −18 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/helpers/drag-and-drop/DropGhost.test.ts +24 −0 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/helpers/drag-and-drop/DropGhost.ts +9 −5 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/helpers/drag-and-drop/drekkenov.ts +1 −1 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/helpers/drag-and-drop/event-handler-factory.test.ts +41 −2 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/helpers/drag-and-drop/event-handler-factory.ts +9 −4 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/store/column/column-mutations.test.ts +4 −4 Go to diff View file
M plugins/taskboard/scripts/taskboard/src/store/column/column-mutations.ts +2 −2 Go to diff View file
M plugins/taskboard/themes/includes/_body.scss +2 −3 Go to diff View file