Implements request #39692 Psalm should not ignore new unit tests No functional change. Why? Psalm used to ignore every file in the core (tests/unit/common) and agiledashboard, cardwall, docman, git, mediawiki, testmanagement and tracker plugins unit test folders. Now, all new unit tests or builders / stubs will be validated. Existing errors in stubs and builders have been added to the baseline so that we don't add more errors. A hand-curated list of unit tests files are ignored. This will let us slowly comb through the list, correct errors and un-ignore each file. Using this ignore list strategy will allow all new files to be validated, but avoid bloating too much the baseline with known problematic test files. We can add them to the baseline on a future patch too and drop the ignore list. Using an explicit ignore list will also make us either correct unit test files that are renamed or baseline them. Some directories in core are still ignored, I figured this change was already big enough. This also raises @psalm-trace errors. @psalm-trace is useful to check what Psalm finds as the type of a variable, but we should not leave them in the codebase (just like we don't leave console logs or var_dumps debug statements). Change-Id: I0267035e42d474f0f9785fe89014bdd8fe7b8545

+2071 −29

Author

Joris MASSON (jmasson) 2024-09-18 12:19

Committer

Joris MASSON (jmasson) 2024-09-19 09:40

Hash 9ec107270210758de0ec024f8fab495d3518d0e2

Parent 398b04a677a80705717395ea9d9c6f58216f68b0

Reference git #tuleap/stable/9ec107270210758de0ec024f8fab495d3518d0e2