Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

request #9408: Prevent mix-up attacks with OpenID Connect

Download Browse

This should not break a provider currently used with the plugin. For more information on the nonce paramter, please see the specification: https://openid.net/specs/openid-connect-core-1_0.html#AuthRequest https://openid.net/specs/openid-connect-core-1_0.html#NonceNotes Change-Id: Ife534cb79dfd4717056afcb9bf4352d4b5299311

+294 −47
Thomas Gerbet (tgerbet) 2016-08-09 20:59
Thomas Gerbet (tgerbet) 2016-08-18 18:45
9f92619d00e2803f021187a663539476650087d6
e5a016884a1bb1a3fa1ffc1f9b8379368d41ee25
git #tuleap/stable/9f92619d00e2803f021187a663539476650087d6

Modified Files

Side by side diff
Inline diff
Name
M plugins/openidconnectclient/include/OpenIDConnectClient/Authentication/AuthorizationDispatcher.php +9 −2 Go to diff View file
M plugins/openidconnectclient/include/OpenIDConnectClient/Authentication/Flow.php +1 −1 Go to diff View file
M plugins/openidconnectclient/include/OpenIDConnectClient/Authentication/IDTokenVerifier.php +14 −2 Go to diff View file
M plugins/openidconnectclient/include/OpenIDConnectClient/Authentication/SessionState.php +18 −4 Go to diff View file
M plugins/openidconnectclient/include/OpenIDConnectClient/Authentication/State.php +27 −4 Go to diff View file
M plugins/openidconnectclient/include/OpenIDConnectClient/Authentication/StateFactory.php +18 −8 Go to diff View file
M plugins/openidconnectclient/include/OpenIDConnectClient/Authentication/StateManager.php +2 −1 Go to diff View file
M plugins/openidconnectclient/include/OpenIDConnectClient/Authentication/StateStorage.php +2 −1 Go to diff View file
A plugins/openidconnectclient/include/OpenIDConnectClient/Authentication/Uri/Generator.php +53 −0 Go to diff View file
M plugins/openidconnectclient/include/autoload.php +3 −2 Go to diff View file
M plugins/openidconnectclient/include/openidconnectclientPlugin.class.php +3 −1 Go to diff View file
M plugins/openidconnectclient/tests/Authentication/FlowTest.php +5 −2 Go to diff View file
M plugins/openidconnectclient/tests/Authentication/IDTokenVerifierTest.php +45 −13 Go to diff View file
M plugins/openidconnectclient/tests/Authentication/StateManagerTest.php +6 −4 Go to diff View file
M plugins/openidconnectclient/tests/Authentication/StateTest.php +3 −2 Go to diff View file
A plugins/openidconnectclient/tests/Authentication/Uri/GeneratorTest.php +85 −0 Go to diff View file