stable
Clone or download
We should not keep forever a PII like the email address when the invitation is flagged as error. Likewise, we should not duplicate the email address when the invitation is successfully used, user table will contain the email, no need to have it at both places. To test: * Both Alice and Bob invites charlie@example.com * Charlie clicks on the invitation link in Bob's email message, and register, and gets a welcome modal. * Both Alice and Bob have received an email to warn them about Charlie's registration * Charlie logout, and click again on invitation links: a message tells that the invitation is already completed and charlie should login instead. Part of request #29614: Invited users shouldn't be mandated to re-confirm their email Change-Id: Id7c612416acdf5f1553c9164ff446d619cfe554f
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | src/common/InviteBuddy/AccountCreationFeedback.php | +1 | −1 | Go to diff View file |
| M | src/common/InviteBuddy/Invitation.php | +7 | −3 | Go to diff View file |
| M | src/common/InviteBuddy/InvitationDao.php | +18 | −9 | Go to diff View file |
| M | src/common/Request/RouteCollector.php | +0 | −2 | Go to diff View file |
| M | src/common/User/Account/Register/DisplayRegisterFormController.php | +3 | −8 | Go to diff View file |
| M | src/common/User/Account/Register/InvitationToEmail.php | +3 | −3 | Go to diff View file |
| M | src/common/User/Account/Register/ProcessRegisterFormController.php | +2 | −7 | Go to diff View file |
| M | tests/integration/tests/InviteBuddy/InvitationDaoTest.php | +40 | −0 | Go to diff View file |
| M | tests/unit/common/Dashboard/User/FirstTimerPresenterBuilderTest.php | +1 | −1 | Go to diff View file |
| M | tests/unit/common/InviteBuddy/AccountCreationFeedbackTest.php | +15 | −15 | Go to diff View file |
| M | tests/unit/common/User/Account/Register/AfterSuccessfulUserRegistrationTest.php | +1 | −1 | Go to diff View file |
| M | tests/unit/common/User/Account/Register/DisplayRegisterFormControllerTest.php | +30 | −12 | Go to diff View file |
| M | tests/unit/common/User/Account/Register/InvitationToEmailRequestExtractorTest.php | +2 | −2 | Go to diff View file |
| M | tests/unit/common/User/Account/Register/InvitationToEmailTest.php | +2 | −2 | Go to diff View file |
| M | tests/unit/common/User/Account/Register/ProcessRegisterFormControllerTest.php | +30 | −10 | Go to diff View file |