stable
Clone or download
Read-only
request #12721: Cryptography API is strict about types
The API was already enforcing types with specific checks, since Tuleap does not support PHP 5.X anymore this can be managed by the PHP engine directly. Due to the sensitive nature of the operations handled, the internal cryptography API is a prime candidate to use it. Implicit type conversion does not mix well with cryptographic operations. Change-Id: Iac4ae24c9b7bf9f3a8efd5879f695b5d0d93b766
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | src/common/Cryptography/Asymmetric/AsymmetricCrypto.php | +5 | −17 | Go to diff View file |
| M | src/common/Cryptography/Asymmetric/SignaturePublicKey.php | +4 | −2 | Go to diff View file |
| M | src/common/Cryptography/Asymmetric/SignatureSecretKey.php | +4 | −2 | Go to diff View file |
| M | src/common/Cryptography/ConcealedString.php | +8 | −15 | Go to diff View file |
| M | src/common/Cryptography/Exception/CannotPerformIOOperationException.php | +4 | −2 | Go to diff View file |
| M | src/common/Cryptography/Exception/CannotSerializeKeyException.php | +3 | −1 | Go to diff View file |
| M | src/common/Cryptography/Exception/InvalidCiphertextException.php | +3 | −1 | Go to diff View file |
| M | src/common/Cryptography/Exception/InvalidKeyException.php | +4 | −2 | Go to diff View file |
| M | src/common/Cryptography/Exception/InvalidSignatureException.php | +4 | −2 | Go to diff View file |
| M | src/common/Cryptography/Exception/UnexpectedOperationFailureException.php | +4 | −2 | Go to diff View file |
| M | src/common/Cryptography/Key.php | +9 | −13 | Go to diff View file |
| M | src/common/Cryptography/KeyFactory.php | +6 | −12 | Go to diff View file |
| M | src/common/Cryptography/Symmetric/EncryptionKey.php | +4 | −2 | Go to diff View file |
| M | src/common/Cryptography/Symmetric/SymmetricCrypto.php | +5 | −11 | Go to diff View file |
| M | tests/simpletest/common/Cryptography/Asymmetric/AsymmetricCryptoTest.php | +10 | −46 | Go to diff View file |
| M | tests/simpletest/common/Cryptography/Asymmetric/SignaturePublicKeyTest.php | +7 | −4 | Go to diff View file |
| M | tests/simpletest/common/Cryptography/Asymmetric/SignatureSecretKeyTest.php | +7 | −4 | Go to diff View file |
| M | tests/simpletest/common/Cryptography/ConcealedStringTest.php | +3 | −12 | Go to diff View file |
| M | tests/simpletest/common/Cryptography/KeyFactoryTest.php | +13 | −9 | Go to diff View file |
| M | tests/simpletest/common/Cryptography/KeyTest.php | +11 | −7 | Go to diff View file |
| M | tests/simpletest/common/Cryptography/Symmetric/EncryptionKeyTest.php | +7 | −4 | Go to diff View file |
| M | tests/simpletest/common/Cryptography/Symmetric/SymmetricCryptoTest.php | +13 | −23 | Go to diff View file |