Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Prevent unlinking an OIDC provider when the user can lock out itself

Download Browse

This contribution removes the possibility to unlink from a provider when no password is set on the account and the account is not linked ot another provider. Part of request #14812: Users signing in via an OIDC provider should be able to create an account without setting a password Change-Id: Ib2ecc13cbb58923ecac6a4e08100763600198f68

+278 −41
Thomas Gerbet (tgerbet) 2020-04-23 19:31
Thomas Gerbet (tgerbet) 2020-04-23 21:20
a274ef8e499a088f5a9ec083cea08676604ee208
3c5f64e1ef9c2341f977ec34bdbdd7ffb689dbe1
git #tuleap/stable/a274ef8e499a088f5a9ec083cea08676604ee208

Modified Files

Side by side diff
Inline diff
Name
M plugins/openidconnectclient/include/OpenIDConnectClient/UserAccount/OIDCProvidersController.php +16 −8 Go to diff View file
M plugins/openidconnectclient/include/OpenIDConnectClient/UserAccount/OIDCProvidersPresenter.php +12 −2 Go to diff View file
M plugins/openidconnectclient/include/OpenIDConnectClient/UserAccount/UnlinkController.php +1 −1 Go to diff View file
M plugins/openidconnectclient/include/OpenIDConnectClient/UserAccount/templates/oidc-providers.mustache +8 −1 Go to diff View file
A plugins/openidconnectclient/include/OpenIDConnectClient/UserMapping/CanRemoveUserMappingChecker.php +37 −0 Go to diff View file
M plugins/openidconnectclient/include/OpenIDConnectClient/UserMapping/UserMapping.php +6 −3 Go to diff View file
M plugins/openidconnectclient/include/OpenIDConnectClient/UserMapping/UserMappingManager.php +35 −10 Go to diff View file
M plugins/openidconnectclient/include/openidconnectclientPlugin.php +32 −6 Go to diff View file
M plugins/openidconnectclient/site-content/fr_FR/LC_MESSAGES/tuleap-openidconnectclient.po +3 −0 Go to diff View file
A plugins/openidconnectclient/tests/unit/UserMapping/CanRemoveUserMappingCheckerTest.php +67 −0 Go to diff View file
M plugins/openidconnectclient/tests/unit/UserMapping/UserMappingManagerTest.php +61 −10 Go to diff View file