Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

fix: request #38666 `worker_events` metric is always empty

Download Browse

Issue introduced in 58f6ee073c78bbfe89dde82cd72764d45958f519. To test: 1. Setup the prometheus_metrics controller 2. Shutdown (on purpose, to make it easier to see the changes) the workers with `systemctl stop tuleap-workers` 3. Create or update some artifacts in order to create some async events 4. Go to the webpage `/metrics` and look for the `worker_events` metric Change-Id: I9ee5f09d8183cc7882192160485537185545f36a

+10 −33
Thomas Gerbet (tgerbet) 2024-07-04 16:04
Thomas Gerbet (tgerbet) 2024-07-04 17:35
a4c05e859780e5346905dab2b0b61dd88d8def3a
a68e2e16aa816e5cf5b1f595d6d9febee93c0e58
git #tuleap/stable/a4c05e859780e5346905dab2b0b61dd88d8def3a

Modified Files

Side by side diff
Inline diff
Name
M plugins/prometheus_metrics/include/MetricsCollector.php +4 −10 Go to diff View file
M plugins/prometheus_metrics/include/MetricsController.php +3 −8 Go to diff View file
M plugins/prometheus_metrics/include/prometheus_metricsPlugin.php +1 −9 Go to diff View file
M plugins/prometheus_metrics/tests/unit/MetricsControllerTest.php +2 −6 Go to diff View file