stable

Clone or download

Read-only

add feature flag, and hide button when no configuration error

part of story #27185 add a team and inherit the existing PI & Iterations Ho to test: - go on program administration, if there is no configuration error only button `remove team` is displayed - set project flag with tuleap config-set feature_flag_program_management_join_train - go back on administration, button `sync open PI` is displayed (disabled as there is no possible action yet) - add a configuration error (exemple remove title semantic), sync button is no longer displayed Please note: - some configuration error are not linked to a specific tracker (example open values are not identical in program and team trackers) so all buttons will be disabled - Button label is not accurate with configuration yet - domain is anemic, there is many dependency presenter who are in Adapter and refactoring it will be long and should not block the addition of new feature Change-Id: I5825486417342dea38dda7dbc4560c6e939ff5c5

Modified Files

Name
A plugins/program_management/include/Adapter/FeatureFlagEnableTeamJoinTrain.php +36 −0 Go to diff View file
M plugins/program_management/include/Adapter/Program/Admin/ProgramAdminPresenter.php +9 −4 Go to diff View file
M plugins/program_management/include/Adapter/Program/Admin/Team/TeamPresenter.php +1 −1 Go to diff View file
M plugins/program_management/include/Adapter/Program/Admin/Team/TeamsPresenterBuilder.php +3 −2 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/CreationCheck/StatusIsAlignedVerifier.php +1 −1 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/ProgramIncrement/Source/Fields/SynchronizedFieldsGatherer.php +3 −2 Go to diff View file
M plugins/program_management/include/DisplayAdminProgramManagementController.php +16 −4 Go to diff View file
M plugins/program_management/include/Domain/Program/Admin/Configuration/ConfigurationErrorsCollector.php +78 −32 Go to diff View file
M plugins/program_management/include/Domain/Program/Admin/Configuration/TrackerErrorPresenter.php +24 −15 Go to diff View file
M plugins/program_management/include/Domain/Program/Backlog/ArtifactUpdatedHandler.php +1 −1 Go to diff View file
M plugins/program_management/include/program_managementPlugin.php +8 −2 Go to diff View file
M plugins/program_management/site-content/fr_FR/LC_MESSAGES/tuleap-program_management.po +3 −0 Go to diff View file
M plugins/program_management/site-content/pt_BR/LC_MESSAGES/tuleap-program_management.po +3 −0 Go to diff View file
M plugins/program_management/templates/admin/teams/admin-list-teams.mustache +23 −9 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Admin/Configuration/ConfigurationErrorPresenterBuilderTest.php +8 −7 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Admin/Configuration/ConfigurationErrorsCollectorTest.php +17 −2 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Admin/Team/TeamsPresenterBuilderTest.php +9 −5 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Backlog/CreationCheck/RequiredFieldVerifierTest.php +3 −2 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Backlog/CreationCheck/SemanticsVerifierTest.php +6 −5 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Backlog/CreationCheck/StatusIsAlignedVerifierTest.php +6 −5 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Backlog/CreationCheck/WorkflowVerifierTest.php +5 −4 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/Backlog/ProgramIncrement/Source/Fields/SynchronizedFieldsGathererTest.php +2 −1 Go to diff View file
M plugins/program_management/tests/unit/Adapter/Program/PlanningAdapterTest.php +2 −1 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/CreationCheck/CanSubmitNewArtifactHandlerTest.php +3 −2 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/CreationCheck/ConfigurationErrorsGathererTest.php +5 −4 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/CreationCheck/IterationCreatorCheckerTest.php +7 −6 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/CreationCheck/ProgramIncrementCreatorCheckerTest.php +7 −6 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/CreationCheck/TimeboxCreatorCheckerTest.php +10 −9 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/CreationCheck/TrackerErrorPresenterTest.php +14 −13 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/ProgramIncrement/Source/Changeset/Values/SynchronizedFieldFromProgramAndTeamTrackersCollectionTest.php +6 −5 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/Source/SourceTrackerCollectionTest.php +2 −1 Go to diff View file
M plugins/program_management/tests/unit/Domain/Program/Backlog/TrackerCollectionTest.php +3 −2 Go to diff View file
M plugins/program_management/themes/program_management/_admin.scss +5 −1 Go to diff View file