stable
Clone or download
Read-only
request #14160: Do not hardcode user's avatar url
We should not compute manually /users/jdoe/avatar.png. This image url is not hashed, and if we need to change the url one day we are stuck. Impacted pages: - Assigned to field in cardwall - Admin > users - Admin > users > user details - Svn > repo > settings > notifications - Trackers > tracker > admin > notifications - Git > repo > settings > notifications - Git > repo > settings > notifications > autocompleter - Project > admin > members - Project > admin > members > autocompleter - Project > admin > members > import preview - Project > admin > ugroups > ugroup > members Note: the route /users/jdoe/avatar.png is kept because viewvc theme is still using it. Change-Id: I13154e1d52a8aee1b8ee915fddce3df04f2c6393
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/cardwall/www/js/cardwall.js | +2 | −3 | Go to diff View file |
| M | plugins/git/include/Git/Notifications/CollectionOfUserToBeNotifiedPresenterBuilder.php | +2 | −1 | Go to diff View file |
| M | plugins/ldap/include/ldapPlugin.php | +4 | −2 | Go to diff View file |
| M | plugins/svn/include/SVN/Notifications/CollectionOfUserToBeNotifiedPresenterBuilder.php | +2 | −1 | Go to diff View file |
| M | plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_List_Bind_UsersValue.class.php | +1 | −0 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Notifications/CollectionOfUserInvolvedInNotificationPresenterBuilder.php | +16 | −3 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Notifications/Settings/Administration/NotificationsAdminSettingsControllerCommon.php | +6 | −2 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Tracker.class.php | +11 | −6 | Go to diff View file |
| M | plugins/tracker/include/trackerPlugin.php | +9 | −3 | Go to diff View file |
| M | plugins/tracker/phpunit/Tracker/Notifications/CollectionOfUserInvolvedInNotificationPresenterBuilderTest.php | +19 | −1 | Go to diff View file |
| M | plugins/tracker/tests/Tracker_FormElement_Field_List_Bind_UsersValueTest.php | +11 | −7 | Go to diff View file |
| M | src/common/Project/Admin/ProjectMembers/ProjectMembersController.php | +3 | −0 | Go to diff View file |
| M | src/common/Project/Admin/ProjectUGroup/Details/MemberPresenter.php | +5 | −0 | Go to diff View file |
| M | src/common/Project/Admin/ProjectUGroup/Details/MembersPresenterBuilder.php | +2 | −1 | Go to diff View file |
| M | src/common/User/Admin/UserDetailsPresenter.php | +5 | −0 | Go to diff View file |
| M | src/common/User/Admin/UserListResultsPresenter.php | +11 | −0 | Go to diff View file |
| M | src/common/User/Admin/UserListResultsUserPresenter.php | +3 | −0 | Go to diff View file |
| M | src/common/User/UserImportCollection.php | +1 | −0 | Go to diff View file |
| M | src/common/Widget/ProjectMembers/AdministratorPresenter.php | +5 | −0 | Go to diff View file |
| M | src/templates/admin/users/user.mustache | +1 | −1 | Go to diff View file |
| M | src/templates/admin/users/userlist.mustache | +1 | −1 | Go to diff View file |
| M | src/templates/project/admin/ugroup-settings-member-list.mustache | +1 | −1 | Go to diff View file |
| M | src/templates/project/members/project-members.mustache | +1 | −1 | Go to diff View file |
| M | src/templates/widgets/project-members.mustache | +1 | −1 | Go to diff View file |
| M | src/www/admin/userlist.php | +1 | −0 | Go to diff View file |
| M | src/www/scripts/project/admin/members-import/project-admin-member-import-preview.mustache | +1 | −1 | Go to diff View file |
| M | src/www/user/autocomplete.php | +5 | −2 | Go to diff View file |
| M | tests/phpunit/common/Project/Admin/ProjectUGroup/Details/MembersPresenterBuilderTest.php | +21 | −18 | Go to diff View file |
| M | tests/simpletest/common/User/UserImportTest.php | +4 | −2 | Go to diff View file |