Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

feat: Validate ORDER BY field

Download Browse

Part of story #39685 Order artifact according to a field Duck typed field are now checked when used in ORDER BY - it must be a valid type - if a list, it must be a single value list *Testing:* Try using ORDER BY with all allowed field types. You should get no errors Change-Id: I47be1769dec54c3fb2040f038b1e8533480e3f24

+699 −14
Kevin Traini (ktraini) 2024-09-19 10:54
Kevin Traini (ktraini) 2024-09-20 11:40
a97fc43da9e575305e45da9261083e05ed01853b
4d024bda9af35d8a3b6bb967633585ab2c5006ac
git #tuleap/stable/a97fc43da9e575305e45da9261083e05ed01853b

Modified Files

Side by side diff
Inline diff
Name
M plugins/crosstracker/include/CrossTracker/REST/v1/CrossTrackerReportsResource.php +7 −3 Go to diff View file
M plugins/crosstracker/include/CrossTracker/Report/CrossTrackerArtifactReportFactory.php +3 −1 Go to diff View file
A plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/DuckTypedField/OrderBy/DuckTypedFieldOrderBy.php +92 −0 Go to diff View file
A plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/DuckTypedField/OrderBy/DuckTypedFieldTypeOrderBy.php +61 −0 Go to diff View file
A plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/DuckTypedField/OrderBy/FieldIdentifierPropertiesOrderBy.php +35 −0 Go to diff View file
A plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/DuckTypedField/OrderBy/FieldIsMultipleValueListFault.php +39 −0 Go to diff View file
M plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/InvalidOrderByBuilder.php +8 −1 Go to diff View file
M plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/QueryValidation/DuckTypedField/DuckTypedFieldChecker.php +32 −0 Go to diff View file
M plugins/crosstracker/include/crosstrackerPlugin.php +1 −0 Go to diff View file
M plugins/crosstracker/site-content/fr_FR/LC_MESSAGES/tuleap-crosstracker.po +7 −3 Go to diff View file
M plugins/crosstracker/site-content/pt_BR/LC_MESSAGES/tuleap-crosstracker.po +5 −3 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Tests/Report/ArtifactReportFactoryInstantiator.php +1 −0 Go to diff View file
A plugins/crosstracker/tests/unit/CrossTracker/Report/Query/Advanced/DuckTypedField/OrderBy/DuckTypedFieldOrderByTest.php +190 −0 Go to diff View file
A plugins/crosstracker/tests/unit/CrossTracker/Report/Query/Advanced/DuckTypedField/OrderBy/DuckTypedFieldTypeOrderByTest.php +116 −0 Go to diff View file
M plugins/crosstracker/tests/unit/CrossTracker/Report/Query/Advanced/InvalidOrderByBuilderTest.php +102 −3 Go to diff View file