Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

chore: Introduce strategy to deal with recipient removal

Download Browse

The current implementation of RecipientManager is a suite of different patterns applied one after another. Let's make it clear and easier to grasp with chain of responsability pattern. This commit also brings the logger a little bit deeper in the stack to get more information on how and when users are removed from notification. Part of: story #10469 choose if I receive a notification when I create/update something Change-Id: If4f0b46c469151527507c3df14dc0d0f022a5191

+171 −79
Manuel Vacelet (vaceletm) 2022-09-20 16:57
Manuel Vacelet (vaceletm) 2022-09-20 18:12
a9945af5a9926989429a93fe12a43bea646e9185
3ca7674799b9a4c5f95b6083246a5645fe01d908
git #tuleap/stable/a9945af5a9926989429a93fe12a43bea646e9185

Modified Files

Side by side diff
Inline diff
Name
M plugins/tracker/include/Tracker/Artifact/Changeset/PostCreation/EmailNotificationTask.php +1 −1 Go to diff View file
A plugins/tracker/include/Tracker/Notifications/GetUserFromRecipient.php +31 −0 Go to diff View file
A plugins/tracker/include/Tracker/Notifications/RecipientRemovalStrategy.php +35 −0 Go to diff View file
M plugins/tracker/include/Tracker/Notifications/RecipientsManager.php +19 −61 Go to diff View file
A plugins/tracker/include/Tracker/Notifications/RemoveRecipient/RemoveRecipientWhenTheyAreInCreationOnlyMode.php +66 −0 Go to diff View file
M plugins/tracker/tests/unit/Tracker/Artifact/Changeset/PostCreation/NotifierCustomSenderTest.php +2 −1 Go to diff View file
M plugins/tracker/tests/unit/Tracker/Notifications/RecipientsManagerTest.php +17 −16 Go to diff View file